Allow custom deploy repo using GH_REPO_SLUG env variable#38
Merged
Syntaf merged 1 commit intoSyntaf:masterfrom May 6, 2018
Merged
Allow custom deploy repo using GH_REPO_SLUG env variable#38Syntaf merged 1 commit intoSyntaf:masterfrom
Syntaf merged 1 commit intoSyntaf:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 81.48% 81.75% +0.27%
==========================================
Files 5 5
Lines 135 137 +2
==========================================
+ Hits 110 112 +2
Misses 25 25
Continue to review full report at Codecov.
|
Owner
|
Thanks for the PR @nocarryr! I'll take a look when I get home and merge is ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification was needed for what may or may not be an typical use case, but I still wanted to share it in case it seemed useful.
I maintain a project that I am not the owner of and cannot directly make certain changes to (the project owner isn't always active and I try to respect that as much as possible). The docs are set up and hosted through my fork, so I needed a way to make
build.pydeploy there.Relevant PR: https://github.com/roger-/pyrtlsdr/pull/82
I welcome your comments/suggestions, etc. If this isn't something you feel should be part of this project, I can just keep my fork up for my own purposes.