fix(frontend:files): load tasks only when a user is logged in to prevent interceptor redirects when refreshing a public link URL

johaven · johaven · commit bda58d609465 · 2026-01-04T00:41:08.000+01:00
diff --git a/frontend/src/app/applications/files/services/files-tasks.service.ts b/frontend/src/app/applications/files/services/files-tasks.service.ts
@@ -18,6 +18,7 @@ import { escapeRegexp } from '../../../common/utils/regexp'
 import { TAB_MENU } from '../../../layout/layout.interfaces'
 import { LayoutService } from '../../../layout/layout.service'
 import { StoreService } from '../../../store/store.service'
+import { UserType } from '../../users/interfaces/user.interface'
 import { FileEvent } from '../interfaces/file-event.interface'
 
 @Injectable({ providedIn: 'root' })
@@ -57,11 +58,18 @@ export class FilesTasksService {
       msg: { success: 'Decompression done', failed: 'Decompression failed' }
     }
   }
+  private currentUserId: number
   private watcher: Subscription = null
   private watch = timer(1000, 1000).pipe(tap(() => this.doWatch()))
 
   constructor() {
-    this.loadAll()
+    this.store.user.subscribe((u: UserType) => {
+      if (u && this.currentUserId !== u?.id) {
+        // Load tasks when the user is defined and has changed to prevent interceptor redirects
+        this.loadAll()
+      }
+      this.currentUserId = u?.id
+    })
   }
 
   addTask(task: FileTask) {
diff --git a/frontend/src/app/applications/files/services/files.service.ts b/frontend/src/app/applications/files/services/files.service.ts
@@ -292,7 +292,7 @@ export class FilesService {
     })
   }
 
-  async openViewerDialog(file: FileModel, directoryFiles: FileModel[], permissions: string) {
+  async openViewerDialog(file: FileModel, directoryFiles: FileModel[], permissions: string): Promise<void> {
     this.http.head(file.dataUrl).subscribe({
       next: async () => {
         // This check is only used for the text viewer; other viewers are read-only or enforce permissions on the backend.

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ export class FilesService {`
`292`	`292`	`})`
`293`	`293`	`}`
`294`	`294`
`295`		`- async openViewerDialog(file: FileModel, directoryFiles: FileModel[], permissions: string) {`
	`295`	`+ async openViewerDialog(file: FileModel, directoryFiles: FileModel[], permissions: string): Promise<void> {`
`296`	`296`	`this.http.head(file.dataUrl).subscribe({`
`297`	`297`	`next: async () => {`
`298`	`298`	`// This check is only used for the text viewer; other viewers are read-only or enforce permissions on the backend.`