removes implicit dependency on sebastian/exporter#159
Closed
ju1ius wants to merge 1 commit intoSymfonyTest:masterfrom
Closed
removes implicit dependency on sebastian/exporter#159ju1ius wants to merge 1 commit intoSymfonyTest:masterfrom
ju1ius wants to merge 1 commit intoSymfonyTest:masterfrom
Conversation
0a41656 to
67fbaaa
Compare
mbabker
requested changes
Jun 23, 2024
Contributor
mbabker
left a comment
There was a problem hiding this comment.
This would break PHPUnit 11 support since Constraint::exporter() is removed.
It looks like PHPUnit\Util\Exporter is available for both 10.5 and 11.x and should avoid the scoping issue.
Member
|
We have merged #166 instead. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158