Skip to content

fix(provider) Fix parsing nested repository arguments#1149

Merged
NoResponseMate merged 1 commit intoSylius:1.14from
loic425:fix/parse-nested-arguments
Feb 13, 2026
Merged

fix(provider) Fix parsing nested repository arguments#1149
NoResponseMate merged 1 commit intoSylius:1.14from
loic425:fix/parse-nested-arguments

Conversation

@loic425
Copy link
Copy Markdown
Member

@loic425 loic425 commented Feb 12, 2026 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

We need this fix to parse findOneBy arguments:

sylius_shop_order_show:
    # ...
    defaults:
        _sylius:
            repository:
                method: findOneBy
                arguments: [tokenValue: $tokenValue]

With the conversion, we have a nested array like this:

new Update(
    // ...
    repositoryMethod: 'findOneBy',
    repositoryArguments: [
        [
            'tokenValue' => "@=request.attributes.get('tokenValue')",
        ],
    ],
),

@loic425 loic425 added the Bug Confirmed bugs or bugfixes. label Feb 12, 2026
@loic425 loic425 force-pushed the fix/parse-nested-arguments branch from 9f34d7a to 0c36a52 Compare February 12, 2026 16:39
@loic425 loic425 changed the base branch from 1.15 to 1.14 February 12, 2026 16:41
@loic425 loic425 mentioned this pull request Feb 12, 2026
Open
@NoResponseMate NoResponseMate merged commit f067e01 into Sylius:1.14 Feb 13, 2026
19 of 20 checks passed
@loic425 loic425 deleted the fix/parse-nested-arguments branch February 13, 2026 13:38
@loic425 loic425 mentioned this pull request Feb 13, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees

No one assigned

Labels

Bug Confirmed bugs or bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic425 @NoResponseMate