Merged
Conversation
f276fd3 to
7435cd3
Compare
loic425
commented
Dec 19, 2025
c7addb6 to
5c18157
Compare
Prometee
requested changes
Dec 28, 2025
Contributor
There was a problem hiding this comment.
What about having a dedicated service instead, I already had cases where depending on resource I would need to get request data then on some others the query ones.
Member
Author
There was a problem hiding this comment.
I do not agree, this behaviour on request package side has been removed, so I think there is a reason. This trait is only used on legacy routing part. So it will be removed on 2.0 (so maybe soon).
Prometee
approved these changes
Dec 29, 2025
7487a3c to
875f157
Compare
NoResponseMate
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1121