[Metadata] Add Php file resource class list factory#1030
Conversation
loic425
commented
Jun 6, 2025
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | part of #1029 |
| License | MIT |
| final class PhpFileResourceClassListFactory implements ResourceClassListFactoryInterface | ||
| { | ||
| public function __construct( | ||
| private readonly ResourceExtractorInterface $metadataExtractor, |
There was a problem hiding this comment.
maybe $resourceExtractor or $resourceMetadataExtractor
There was a problem hiding this comment.
Since the whole point of the this class to call phpFileResourceMetataResourceExtractor, then would be cool to use in the name to understand it at glance without checking service definition.
| private readonly ResourceExtractorInterface $metadataExtractor, | |
| private readonly ResourceExtractorInterface $phpFileResourceMetadataExtractor, |
| /** | ||
| * @inheritdoc | ||
| */ |
There was a problem hiding this comment.
| /** | |
| * @inheritdoc | |
| */ |
| { | ||
| public function __construct( | ||
| private readonly ResourceExtractorInterface $metadataExtractor, | ||
| private readonly ?ResourceClassListFactoryInterface $decorated = null, |
There was a problem hiding this comment.
Is it possible for .inner to be empty within decoration process?
There was a problem hiding this comment.
The way of having that nullable decorated is that we can switch the decorated and the decorator, even in userland if needed.
| final class PhpFileResourceClassListFactory implements ResourceClassListFactoryInterface | ||
| { | ||
| public function __construct( | ||
| private readonly ResourceExtractorInterface $metadataExtractor, |
There was a problem hiding this comment.
Since the whole point of the this class to call phpFileResourceMetataResourceExtractor, then would be cool to use in the name to understand it at glance without checking service definition.
| private readonly ResourceExtractorInterface $metadataExtractor, | |
| private readonly ResourceExtractorInterface $phpFileResourceMetadataExtractor, |
dafa2c3 to
1fcee5e
Compare
1fcee5e to
972f50a
Compare
| - | ||
| name: Create-project with skeleton | ||
| run: | | ||
| set -x |
There was a problem hiding this comment.
I added back this debug mode and that works... strange behaviour here.
Maybe that's a luck here.