Skip to content

[BC BREAK] Symfony 4.0 compatibility, part #1#9366

Merged
pamil merged 21 commits intoSylius:masterfrom
pamil:1.2-symfony-4.0-application
Apr 27, 2018
Merged

[BC BREAK] Symfony 4.0 compatibility, part #1#9366
pamil merged 21 commits intoSylius:masterfrom
pamil:1.2-symfony-4.0-application

Conversation

@pamil
Copy link
Copy Markdown
Contributor

@pamil pamil commented Apr 25, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? yes
Related tickets related to #9062, fixes #9186, closes #9277
License MIT

@pamil pamil added BC Break Maintenance CI configurations, READMEs, releases, etc. labels Apr 25, 2018
@pamil pamil added this to the 1.2 milestone Apr 25, 2018
@pamil pamil self-assigned this Apr 25, 2018
@pamil pamil force-pushed the 1.2-symfony-4.0-application branch from d27db67 to 915f017 Compare April 25, 2018 13:05
@pamil pamil force-pushed the 1.2-symfony-4.0-application branch 2 times, most recently from 265d39a to fa9d513 Compare April 25, 2018 14:50
@pamil pamil force-pushed the 1.2-symfony-4.0-application branch from fa9d513 to 5fb2b2d Compare April 25, 2018 15:00
@pamil
Copy link
Copy Markdown
Contributor Author

pamil commented Apr 25, 2018

If the build passes for Symfony 3.4.*, it's good to merge to start more work based on it.

@pamil pamil removed this from the 1.2 milestone Apr 27, 2018
@pamil pamil force-pushed the 1.2-symfony-4.0-application branch from 59d5c53 to 8376218 Compare April 27, 2018 11:56
lchrusciel
lchrusciel approved these changes Apr 27, 2018
View reviewed changes
src/Sylius/Behat/Resources/config/services/pages/admin/order.xml
</parameters>

<services>
<defaults public="true" />
Copy link
Copy Markdown
Contributor

@lchrusciel lchrusciel Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed, as all (as I suppose) services here are explicitly declared as not public?

Copy link
Copy Markdown
Contributor Author

@pamil pamil Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added it automatically to every services file, it can be removed in the future without much effort and no BC break.

@pamil pamil changed the title Symfony 4.0 compatibility [BC BREAK] Symfony 4.0 compatibility, part #1 Apr 27, 2018
@pamil pamil merged commit f7d42d2 into Sylius:master Apr 27, 2018
@pamil pamil deleted the 1.2-symfony-4.0-application branch April 27, 2018 13:09
@lchrusciel lchrusciel mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lchrusciel lchrusciel lchrusciel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pamil pamil

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test packages on both Symfony 3 and Symfony 4

3 participants

@pamil @teohhanhui @lchrusciel