Improving the management of the collection form type#627
Improving the management of the collection form type#627arnolanglade wants to merge 15 commits intoSylius:masterfrom
Conversation
|
Looks very nice! I briefly looked at the implementation and it seems good as well, but I'd like to check it again before merging, when I have a bit more time. Thank you Arnaud! You're the man. ;) |
|
@pjedrzejewski : Don't merge it, I forgot [WIP] in title. I just want to know if you are interested by this PR. @stloyd : I need to clean lot of stuff... This PR break other form too! |
There was a problem hiding this comment.
@pjedrzejewski, @pjedrzejewski : Do I remove it?
There was a problem hiding this comment.
i would rename the macro notification -> flashes-errors-alerts or something similar and remove these
|
@Arn0d What's status of this? |
|
@stloyd : I am working product images collection. There is a collection form type in Zone page too, I have to manage it. I have to add some missing translations too and fix the build. |
There was a problem hiding this comment.
@Sylius this script is useless for now, what do I do? Do I remove it ?
There was a problem hiding this comment.
If it's not used anymore at that file, yes.
|
@pjedrzejewski : ouff, good ! |
|
ping @pjedrzejewski |
|
👍 for merging this asap. |
|
Likewise! 👍 Exciting to see this live |
|
@pjedrzejewski can you give me some news about it, plz? |
|
I was not able to come up with something satisfying so far, but there is nothing more important for me to merge/work on right now, sorry and please give me a few days more. Cheers. |
|
No problem, I just wanted some news. Thanks! |
|
@pjedrzejewski snif, snif 🐰 |
|
@pjedrzejewski I saw your rebase, are you still on this one? It's one of must have IMO. |
|
Any updates on this? Was going to implement this myself as it's broken functionality without it but if it's coming soon I'll use my time on something else |
|
@Arn0d @stloyd @jackpf I done this from scratch with a bit different approach, solving all the problems on the frontend side and with a lot smaller changeset... Last part to implement is product property adding interface, but this will be done after components merge, because there is a lot of BC breaks with regard to product attributes.
|
|
Nice one, looks good! |
|
Did you push it somewhere ? |
|
Hi guys, sorry to bother you all but what's the status of this pr? We need the collection management improvements for a site that's going live in a couple of weeks, so we're on the verge of having to implement it ourselves. Are there issues on the pull request I could potentially help with? |
|
Ping @Arn0d @pjedrzejewski |
|
@umpirsky yes, I am there! @pjedrzejewski Any news about your refactoring? Do I try a rebase ? Do I rewrite it (with small PR)? |
|
Is this PR supposed to also fix the inability of deleting a product image? |
There was a problem hiding this comment.
The filter used should probably be 'sylius_small', correct?
There was a problem hiding this comment.
yes but this PR is outdated, Pawel will rework it.
|
🐶 |
It just work with country form, it looks like :
@jjanvier, @pjedrzejewski, @stloyd : Do you like it? Feedback are welcome! Thanks