Conversation
|
@pjedrzejewski Can you have a look and say what we really need here? |
|
@stloyd I'll check the functionality today. Except that, I'd say that we should add Behat scenarios, for the backend and frontend features. |
|
@stloyd @pjedrzejewski Sorry, I dropped the ball on this.. we still need to change the way the reviewer is handled (guest vs. user) and add aggregate rating to the product. At least that's what I had in mind, open for more ideas :) |
|
is it available ? can I download this bundle? |
|
@aniltc not yet merged |
|
ca we expect soon??? |
|
ping @Richtermeister @stloyd |
|
@winzou The biggest roadblock I got hung up on was the Reviewer/GuestReviewer issue. Let me know if you want me to elaborate on the problem.. Also, the way the form is integrated into the product page is pretty weak.. Lastly, I'm not sure if the 5 star rating could be abstracted more.. some people might want a different scale/type of rating. |
|
@Richtermeister do you think it's possible for you to get this working with less features: don't use GuestReviewer, simple integration in product page and basic 5 star rating? Just the basis so that we can merge it. We better move by little steps. Once merged it will be used by others and these features will get implemented naturally. |
|
@winzou Yes I can do that. Will do my best before the weekend. |
|
Awesome! |
|
Totally agree with @winzou. Let's do smaller steps. :) And to be honest I'm not sure how to handle the GuestReviewer as well, same issue like with Orders without registration. |
|
@Richtermeister I see you rebased it, great. It just needs to work (I see that Travis fails on a guest reviewer stuff) and we can merge it! Thanks ;) |
|
@winzou Yes, I have a bunch of unpushed edits. Looking for time to wrap this up. |
9241726 to
07cc6cf
Compare
07cc6cf to
199e634
Compare
|
Closing in favor of #3300. |
Replaces #431.