Skip to content

Review bundle#611

Closed
stloyd wants to merge 3 commits intoSylius:masterfrom
stloyd:feature/review_bundle
Closed

Review bundle#611
stloyd wants to merge 3 commits intoSylius:masterfrom
stloyd:feature/review_bundle

Conversation

@stloyd
Copy link
Copy Markdown
Contributor

@stloyd stloyd commented Nov 17, 2013

Replaces #431.

@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Nov 17, 2013

@pjedrzejewski Can you have a look and say what we really need here?

@pjedrzejewski
Copy link
Copy Markdown
Contributor

@stloyd I'll check the functionality today. Except that, I'd say that we should add Behat scenarios, for the backend and frontend features.

@Richtermeister
Copy link
Copy Markdown
Contributor

@stloyd @pjedrzejewski Sorry, I dropped the ball on this.. we still need to change the way the reviewer is handled (guest vs. user) and add aggregate rating to the product. At least that's what I had in mind, open for more ideas :)
Will work on this this week.

@aniltc
Copy link
Copy Markdown

aniltc commented Dec 3, 2013

is it available ? can I download this bundle?

@jjanvier
Copy link
Copy Markdown
Contributor

jjanvier commented Dec 3, 2013

@aniltc not yet merged

@aniltc
Copy link
Copy Markdown

aniltc commented Dec 3, 2013

ca we expect soon???

@winzou
Copy link
Copy Markdown
Contributor

winzou commented Jan 21, 2014

ping @Richtermeister @stloyd
There is a lot of work already done, let's not waste it!
What is the status? What is missing?

@Richtermeister
Copy link
Copy Markdown
Contributor

@winzou The biggest roadblock I got hung up on was the Reviewer/GuestReviewer issue. Let me know if you want me to elaborate on the problem..

Also, the way the form is integrated into the product page is pretty weak..

Lastly, I'm not sure if the 5 star rating could be abstracted more.. some people might want a different scale/type of rating.

@winzou
Copy link
Copy Markdown
Contributor

winzou commented Jan 22, 2014

@Richtermeister do you think it's possible for you to get this working with less features: don't use GuestReviewer, simple integration in product page and basic 5 star rating? Just the basis so that we can merge it.

We better move by little steps. Once merged it will be used by others and these features will get implemented naturally.

@Richtermeister
Copy link
Copy Markdown
Contributor

@winzou Yes I can do that. Will do my best before the weekend.

@winzou
Copy link
Copy Markdown
Contributor

winzou commented Jan 22, 2014

Awesome!

@pjedrzejewski
Copy link
Copy Markdown
Contributor

Totally agree with @winzou. Let's do smaller steps. :) And to be honest I'm not sure how to handle the GuestReviewer as well, same issue like with Orders without registration.

@winzou
Copy link
Copy Markdown
Contributor

winzou commented Feb 3, 2014

@Richtermeister I see you rebased it, great. It just needs to work (I see that Travis fails on a guest reviewer stuff) and we can merge it! Thanks ;)

@Richtermeister
Copy link
Copy Markdown
Contributor

@winzou Yes, I have a bunch of unpushed edits. Looking for time to wrap this up.

@stloyd stloyd force-pushed the feature/review_bundle branch from 07cc6cf to 199e634 Compare November 1, 2014 11:48
@pjedrzejewski pjedrzejewski removed this from the v1.0.0-ALPHA1 milestone May 11, 2015
@pjedrzejewski
Copy link
Copy Markdown
Contributor

Closing in favor of #3300.

@stloyd stloyd deleted the feature/review_bundle branch December 14, 2015 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants