Skip to content

[Travis] New migrations policy#3326

Closed
pamil wants to merge 2 commits intoSylius:masterfrom
pamil:migrations-travis-support
Closed

[Travis] New migrations policy#3326
pamil wants to merge 2 commits intoSylius:masterfrom
pamil:migrations-travis-support

Conversation

@pamil
Copy link
Copy Markdown
Contributor

@pamil pamil commented Sep 22, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #3303
License MIT

Deleted all existing migrations and created one that builds Sylius v0.15.0 database structure from scratch.

@pamil pamil mentioned this pull request Sep 22, 2015
@pamil pamil force-pushed the migrations-travis-support branch from 03052a4 to 51005bb Compare September 22, 2015 08:49
@pamil pamil mentioned this pull request Sep 24, 2015
7 tasks
@michalmarcinkowski
Copy link
Copy Markdown
Contributor

👍 Please update the changelog and we can get this merged! 😉

@winzou
Copy link
Copy Markdown
Contributor

winzou commented Sep 25, 2015

Wow, you cannot just delete migrations and let us deal with it when upgrading our sylius!
Please keep these migrations and add a new one from scratch to the first already existing migration.

@michalmarcinkowski
Copy link
Copy Markdown
Contributor

@winzou all migrations will be available in v0.15, so you can use whatever you need. Then in order to jump to v0.16 you would need to run just one migration. We plan to make one migration file per release to ease upgrades (all PRs will introduce their migrations and just before release we will merged them all into one file).

Does it sound good for you or you have some better idea? (related discussion #3303)

@pamil
Copy link
Copy Markdown
Contributor Author

pamil commented Sep 25, 2015

@michalmarcinkowski done! :)

@winzou
Copy link
Copy Markdown
Contributor

winzou commented Sep 28, 2015

What is the point of merging migrations?

For this PR, I would checkout Sylius just before the first migration, then do a do:mi:di, then add the generated file here. It would keep history and ease migrations (what if I want to update from 0.14 to dev-master?). I just hope that every schema change has its migration...

@pamil
Copy link
Copy Markdown
Contributor Author

pamil commented Sep 29, 2015

@winzou New migrations will allow to migrate 0.15 -> 0.16 in just one migration. Development branch master will contain unmerged migrations so migrating 0.15 -> master would be easy to. The only drawback I can see is that migrating master -> next stable version would not be easily available - @michalmarcinkowski?

@pjedrzejewski pjedrzejewski added the RFC Discussions about potential changes or new features. label Oct 21, 2015
@pjedrzejewski pjedrzejewski modified the milestones: v0.16.0, v0.17.0 Oct 21, 2015
@michalmarcinkowski michalmarcinkowski removed this from the v0.17.0 milestone Dec 11, 2015
@pamil pamil closed this Mar 22, 2016
@pamil pamil deleted the migrations-travis-support branch March 22, 2016 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFC Discussions about potential changes or new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants