Walkthrough

Three Behat CLI context files are migrated from docblock-style step annotations (@When, @Then, @Given) to PHP 8 attributes (#[When], #[Then], #[Given]). Required use statements for Behat\Step are added. No functional behavior or method signatures change; only annotation syntax is modernized.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• GSadee
• TheMilek

Poem

🐰 Attributes now bloom where docblocks once lay,
PHP 8 wisdom lights the Behat way,
Three contexts refined with modern flair,
Steps declare themselves with attributes to share! ✨

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

src/Sylius/Behat/Context/Cli/CancelUnpaidOrdersContext.php (1)

16-18: Imports are not sorted alphabetically.

Per coding guidelines, use imports should be sorted alphabetically. Behat\Behat\Context\Context should precede Behat\Step\*, and Then should precede When.

Proposed fix

-use Behat\Step\When;
-use Behat\Step\Then;
 use Behat\Behat\Context\Context;
+use Behat\Step\Then;
+use Behat\Step\When;

As per coding guidelines: "Sort PHP use imports alphabetically and group by type (classes, functions, constants)".

src/Sylius/Behat/Context/Cli/InstallerContext.php (1)

16-19: Same import ordering issue — Behat\Behat\* should come first.

Proposed fix

-use Behat\Step\When;
-use Behat\Step\Given;
-use Behat\Step\Then;
 use Behat\Behat\Context\Context;
+use Behat\Step\Given;
+use Behat\Step\Then;
+use Behat\Step\When;

As per coding guidelines: "Sort PHP use imports alphabetically and group by type (classes, functions, constants)".

src/Sylius/Behat/Context/Cli/ChangeAdminPasswordContext.php (1)

16-18: Same import ordering issue — Behat\Behat\* should come first.

Proposed fix

-use Behat\Step\When;
-use Behat\Step\Then;
 use Behat\Behat\Context\Context;
+use Behat\Step\Then;
+use Behat\Step\When;

As per coding guidelines: "Sort PHP use imports alphabetically and group by type (classes, functions, constants)".

• X
• Mastodon
• Reddit
• LinkedIn