Merged
Conversation
📝 WalkthroughWalkthroughThis pull request migrates the Sylius ShippingBundle dependency injection configuration from XML to PHP. The bundle extension now loads PHP config files (replacing XmlFileLoader with PhpFileLoader) and XML service files were removed and replaced by corresponding PHP service configuration files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
25 tasks
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
7daa536 to
44a0fbf
Compare
TheMilek
reviewed
Feb 2, 2026
| use Sylius\Bundle\ShippingBundle\Doctrine\ORM\ShippingMethodRepository; | ||
|
|
||
| return static function (ContainerConfigurator $container) { | ||
| $services = $container->services(); |
Member
There was a problem hiding this comment.
Suggested change
| $services = $container->services(); |
|
|
||
| return static function (ContainerConfigurator $container) { | ||
| $services = $container->services(); | ||
| $parameters = $container->parameters(); |
Member
There was a problem hiding this comment.
Suggested change
| $parameters = $container->parameters(); |
|
|
||
| return static function (ContainerConfigurator $container) { | ||
| $services = $container->services(); | ||
| $parameters = $container->parameters(); |
Member
There was a problem hiding this comment.
Suggested change
| $parameters = $container->parameters(); |
Comment on lines
+35
to
+37
| $services = $container->services(); | ||
| $parameters = $container->parameters(); | ||
| $container->import('services/**.php'); |
Member
There was a problem hiding this comment.
Suggested change
| $services = $container->services(); | |
| $parameters = $container->parameters(); | |
| $container->import('services/**.php'); | |
| $container->import('services/**.php'); | |
| $parameters = $container->parameters(); | |
| $services = $container->services(); |
Comment on lines
+41
to
+45
| $services->set('sylius.registry.shipping_methods_resolver', PrioritizedServiceRegistry::class) | ||
| ->args([ | ||
| '%sylius.shipping_methods_resolver.interface%', | ||
| 'Shipping methods resolver', | ||
| ]); |
Member
There was a problem hiding this comment.
Suggested change
| $services->set('sylius.registry.shipping_methods_resolver', PrioritizedServiceRegistry::class) | |
| ->args([ | |
| '%sylius.shipping_methods_resolver.interface%', | |
| 'Shipping methods resolver', | |
| ]); |
this is duplicated in registry.php 🤔
44a0fbf to
d86526e
Compare
TheMilek
approved these changes
Feb 4, 2026
This was referenced Feb 4, 2026
Merged
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Refactor
New Features