Skip to content

[XML2PHP] InventoryBundle#18763

Merged
TheMilek merged 1 commit intoSylius:2.3from
crydotsnake:xml2php/inventory
Feb 4, 2026
Merged

[XML2PHP] InventoryBundle#18763
TheMilek merged 1 commit intoSylius:2.3from
crydotsnake:xml2php/inventory

Conversation

@crydotsnake
Copy link
Copy Markdown
Member

@crydotsnake crydotsnake commented Jan 31, 2026

Q A
Branch? 2.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #18490
License MIT

Summary by CodeRabbit

  • Chores
    • Updated service configuration format for the inventory system. Service definitions and dependencies have been restructured without affecting end-user functionality or public interfaces.

@crydotsnake crydotsnake requested review from a team as code owners January 31, 2026 10:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

The changes migrate the Sylius InventoryBundle's dependency injection configuration from XML to PHP-based format. The extension loader is updated to use PhpFileLoader instead of XmlFileLoader, a new services.php file replaces the XML configuration with equivalent service definitions, and the "service" symbol is whitelisted in the composer-require-checker configuration.

Changes

Cohort / File(s) Summary
Configuration Format Migration
src/Sylius/Bundle/InventoryBundle/DependencyInjection/SyliusInventoryExtension.php, src/Sylius/Bundle/InventoryBundle/Resources/config/services.php, src/Sylius/Bundle/InventoryBundle/Resources/config/services.xml
Migrated dependency injection configuration from XML to PHP format. Updated extension to use PhpFileLoader instead of XmlFileLoader, added new services.php with equivalent service definitions (AvailabilityChecker, InStockValidator, InventoryExtension), and removed corresponding XML configuration.
Validation Configuration
composer-require-checker.json
Added "service" to the symbol-whitelist to allow this symbol in composition analysis.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop hop, XML takes a bow,
PHP services reign here now,
From structured tags to functions clean,
The prettiest configs I've ever seen!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[XML2PHP] InventoryBundle' accurately reflects the main change: converting the InventoryBundle's service configuration from XML to PHP format.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

TheMilek
TheMilek previously approved these changes Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants