Skip to content

[New routing] Convert sylius_admin_catalog_promotion_product_variant_…#18746

Merged
NoResponseMate merged 1 commit intoSylius:new-routingfrom
loic425:catalog_promotion_product_variants
Feb 3, 2026
Merged

[New routing] Convert sylius_admin_catalog_promotion_product_variant_…#18746
NoResponseMate merged 1 commit intoSylius:new-routingfrom
loic425:catalog_promotion_product_variants

Conversation

@loic425
Copy link
Copy Markdown
Member

@loic425 loic425 commented Jan 22, 2026 •
edited
Loading

Q A
Branch? new-routing
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets partially #18212
License MIT

Previous YAML routing:

sylius_admin_catalog_promotion_product_variant_index:
    path: /catalog-promotions/{id}/variants
    methods: [GET]
    condition: "context.isSyliusRoutingBcLayerEnabled('admin_product_variant')"
    defaults:
        _controller: sylius.controller.product_variant::indexAction
        _sylius:
            section: admin
            grid: sylius_admin_product_variant_with_catalog_promotion
            template: "@SyliusAdmin/catalog_promotion/product_variant/index.html.twig"
            permission: true
            vars:
                catalogPromotion: expr:service('sylius.repository.catalog_promotion').find($id)

@loic425 loic425 requested review from a team as code owners January 22, 2026 16:35
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Jan 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 22, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@loic425 loic425 mentioned this pull request Jan 22, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 22, 2026 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@loic425 loic425 force-pushed the catalog_promotion_product_variants branch from ec02496 to 1299753 Compare February 2, 2026 15:45
@NoResponseMate NoResponseMate merged commit 00b3c95 into Sylius:new-routing Feb 3, 2026
36 checks passed
@loic425 loic425 deleted the catalog_promotion_product_variants branch February 3, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees

No one assigned

Labels

Admin AdminBundle related issues and PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic425 @NoResponseMate