[API] Payment Request fix default action when IRI is given#18722
Merged
TheMilek merged 7 commits intoSylius:2.1from Jan 16, 2026
Merged
[API] Payment Request fix default action when IRI is given#18722TheMilek merged 7 commits intoSylius:2.1from
TheMilek merged 7 commits intoSylius:2.1from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
4 tasks
1e8ecb2 to
51731af
Compare
diimpp
reviewed
Jan 15, 2026
...ylius/Bundle/ApiBundle/Serializer/ContextBuilder/PaymentRequestActionAwareContextBuilder.php
Outdated
Show resolved
Hide resolved
…equestActionAwareContextBuilder.php Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
… into fix-default-action
d8d3b90 to
b2a6e12
Compare
b2a6e12 to
60718c9
Compare
TheMilek
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the handling of payment request actions by also handling IRI payment method.
Changes
1. Remove explicit action parameter from Behat tests
actionfield from payment request context in Behat tests2. Enhanced PaymentRequestActionAwareContextBuilder
paymentMethodCodeparameterIriToIdentifierConverterInterfaceto handle IRI format payment method codespaymentMethodCodeis provided as an IRI (e.g.,/api/v2/shop/payment-methods/code), it's automatically converted to the identifier before determining the default actionBenefits
Technical Details
The
PaymentRequestActionAwareContextBuildernow:paymentMethodCodeis an IRIThis change maintains backward compatibility while adding support for IRI-based payment method references.