Skip to content

[Behat] Migrate cart scenarios to chromedriver#18609

Merged
Wojdylak merged 1 commit intoSylius:2.1from
Rafikooo:behat/replace-javascript-tag-with-chromedriver
Dec 1, 2025
Merged

[Behat] Migrate cart scenarios to chromedriver#18609
Wojdylak merged 1 commit intoSylius:2.1from
Rafikooo:behat/replace-javascript-tag-with-chromedriver

Conversation

@Rafikooo
Copy link
Copy Markdown
Contributor

@Rafikooo Rafikooo commented Nov 30, 2025

Replaces the @javascript tag with @mink:chromedriver in shop cart Behat feature files to use the explicit Chromedriver driver configuration.

Affects 13 feature files in features/shop/cart/.

Summary by CodeRabbit

  • Tests

    • Updated test execution configuration across multiple test files for improved test reliability and consistency.
  • Chores

    • Migrated test infrastructure to optimize testing environment.

✏️ Tip: You can customize this high-level summary in your review settings.

@Rafikooo Rafikooo requested review from a team as code owners November 30, 2025 14:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 30, 2025

Walkthrough

This pull request updates Behat test tags across multiple shopping cart feature files, systematically replacing @javascript tags with @mink:chromedriver tags. The changes modify test runner configuration without altering scenario steps, assertions, or functionality.

Changes

Cohort / File(s) Summary
Cart feature tag updates
features/shop/cart/shopping_cart/adding_products_with_quantity_to_cart.feature, features/shop/cart/shopping_cart/clearing_cart.feature, features/shop/cart/shopping_cart/continuing_cart_processing_from_ui_in_api.feature, features/shop/cart/shopping_cart/e2e/adding_product_to_cart.feature, features/shop/cart/shopping_cart/e2e/adding_product_with_options_to_cart.feature, features/shop/cart/shopping_cart/e2e/adding_product_with_variants_to_cart.feature, features/shop/cart/shopping_cart/e2e/changing_quantity_of_product_in_cart.feature, features/shop/cart/shopping_cart/e2e/ui/adding_product_to_cart_with_prices_dependent_on_channel.feature, features/shop/cart/shopping_cart/e2e/ui/verify_add_to_cart_button_state.feature, features/shop/cart/shopping_cart/having_proper_product_image_displayed_in_cart.feature, features/shop/cart/shopping_cart/maintaining_cart_after_authorization.feature, features/shop/cart/shopping_cart/viewing_cart_summary_in_many_channels.feature, features/shop/cart/viewing_total_quantity_of_the_cart.feature
Replaced @javascript tag with @mink:chromedriver tag in background sections and/or scenario tags across all cart-related feature files. Test steps and assertions remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward, repetitive configuration update across test files. All changes follow the same pattern—simple tag replacement with no logic modifications or functional impact.

Possibly related PRs

  • Sylius/Sylius#17873 — Modifies BDD feature files' test runner tags in overlapping cart/checkout feature files with similar @javascript to @mink:chromedriver replacements.
  • Sylius/Sylius#17852 — Updates Behat feature files' test-runner tags in shopping cart-related feature files with identical tag switching pattern.

Suggested labels

Behat, Maintenance

Suggested reviewers

  • GSadee
  • mpysiak

Poem

🐰 With tags we hop from script to chrome,
Our tests now drive through Mink's new home,
Where Chromedriver steers the scene,
Each cart test sharper, faster, clean! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: migrating cart scenarios from @javascript tags to @mink:chromedriver across 13 feature files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 30, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@Rafikooo Rafikooo changed the title Replace @javascript tag with @mink:chromedriver in cart features [Behat] Migratecart scenarios to chromedriver Nov 30, 2025
@Rafikooo Rafikooo changed the title [Behat] Migratecart scenarios to chromedriver [Behat] Migrate cart scenarios to chromedriver Nov 30, 2025
@Wojdylak Wojdylak merged commit 6223dee into Sylius:2.1 Dec 1, 2025
27 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants