Merged
Conversation
📝 WalkthroughWalkthroughMigrates AddressingBundle service configuration from XML to PHP: replaces XmlFileLoader with PhpFileLoader in the Extension and converts multiple Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
06ff808 to
fb6f89a
Compare
25 tasks
fb6f89a to
8e1c87a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/Sylius/Bundle/AddressingBundle/Resources/config/services/form.php`:
- Around line 29-105: The services in this PHP service config were left private
because the XML default public="true" was not migrated; after the $services =
$container->services() call add a defaults() call to make them public (call
$services->defaults()->public()) so all form services like
'sylius.form.type.address', 'sylius.form.type.country', 'sylius.form.type.zone',
'sylius.form.type.zone_member' etc. keep public visibility as in the original
form.xml.
091446a to
5882c58
Compare
5882c58 to
7638c0f
Compare
TheMilek
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit