src/Sylius/Behat/Service/Setter/CookieSetter.php (1)

49-54: Tighten the parameter type for ensureDriverStarted.

Using mixed is unnecessarily broad. Prefer DriverInterface to reflect actual usage and intent. Also add the missing import (keeps use list alphabetized).

+use Behat\Mink\Driver\DriverInterface;
@@
-    private function ensureDriverStarted(mixed $driver): void
+    private function ensureDriverStarted(DriverInterface $driver): void
     {
         if (($driver instanceof ChromeDriver || $driver instanceof PantherDriver) && !$driver->isStarted()) {
             $driver->start();
         }
     }

As per coding guidelines.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/Sylius/Behat/Service/Setter/CookieSetter.php (1)

71-80: Fix false-positive base_url detection for “other” drivers.

str_contains can match unrelated domains (e.g., http://shop in http://shopper.example.com), skipping required preparation and setting cookies on the wrong host. Use a prefix match on normalized base_url and also treat blank pages as not loaded.

-        return !str_contains($session->getCurrentUrl(), $this->minkParameters['base_url']);
+        return $this->isPageNotLoaded($session->getCurrentUrl())
+            || !str_starts_with(
+                $session->getCurrentUrl(),
+                rtrim((string) $this->minkParameters['base_url'], '/') . '/'
+            );

If you prefer host-level certainty:

$curr = parse_url($session->getCurrentUrl(), \PHP_URL_HOST);
$base = parse_url((string) $this->minkParameters['base_url'], \PHP_URL_HOST);
return $this->isPageNotLoaded($session->getCurrentUrl()) || ($curr !== $base);

src/Sylius/Behat/Service/Setter/CookieSetter.php (3)

37-41: SymfonyDriver cookie: ensure host presence; consider explicit path.

parse_url may return null if base_url is misconfigured. Guard and default path to '/' to avoid ambiguity in BrowserKit.

-            $driver->getClient()->getCookieJar()->set(
-                new Cookie($name, $value, null, null, parse_url($this->minkParameters['base_url'], \PHP_URL_HOST)),
-            );
+            $host = parse_url((string) $this->minkParameters['base_url'], \PHP_URL_HOST);
+            if ($host === null) {
+                throw new \InvalidArgumentException('Parameter "base_url" must include a host to set cookies with SymfonyDriver.');
+            }
+            $driver->getClient()->getCookieJar()->set(
+                new Cookie($name, $value, null, '/', $host),
+            );

---

49-55: Narrow the type of ensureDriverStarted() to DriverInterface.

Use the interface returned by Session::getDriver() instead of mixed.

-    private function ensureDriverStarted(mixed $driver): void
+    private function ensureDriverStarted(DriverInterface $driver): void
     {
         if (($driver instanceof ChromeDriver || $driver instanceof PantherDriver) && !$driver->isStarted()) {
             $driver->start();
         }
     }

And add the import (kept alphabetical within Behat\Mink\Driver group):

-use Behat\Mink\Driver\PantherDriver;
+use Behat\Mink\Driver\DriverInterface;
+use Behat\Mink\Driver\PantherDriver;
 use Behat\Mink\Driver\Selenium2Driver;
 use Behat\Mink\Session;

---

82-85: Broaden “blank page” detection (optional).

Covers about:blank#blocked and trims whitespace; keeps current behavior for data:, and exact blank.

-    private function isPageNotLoaded(string $url): bool
-    {
-        return in_array($url, ['', 'about:blank', 'data:,'], true);
-    }
+    private function isPageNotLoaded(string $url): bool
+    {
+        $url = trim($url);
+        return $url === ''
+            || str_starts_with($url, 'about:blank')
+            || $url === 'data:,';
+    }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro