Skip to content

[New routing] Admin product crud #18215

Merged
NoResponseMate merged 1 commit intoSylius:new-routingfrom
loic425:admin-product-crud
Jul 17, 2025
Merged

[New routing] Admin product crud #18215
NoResponseMate merged 1 commit intoSylius:new-routingfrom
loic425:admin-product-crud

Conversation

@loic425
Copy link
Copy Markdown
Member

@loic425 loic425 commented Jul 7, 2025 •
edited
Loading

Q A
Branch? new-routing
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets partially #18212
License MIT

Based on #18214

The context for legacy routing bc layer is explained a lot here.
Sylius/SyliusResourceBundle#1051

Looks promising :)
image

@loic425 loic425 requested review from a team as code owners July 7, 2025 14:25
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Jul 7, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@loic425 loic425 changed the title Admin product crud [New routing] Admin product crud Jul 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 7, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@loic425 loic425 mentioned this pull request Jul 7, 2025
Open
@loic425 loic425 force-pushed the admin-product-crud branch 4 times, most recently from 7bf8d7f to 253052e Compare July 16, 2025 08:56
loic425
loic425 commented Jul 16, 2025
View reviewed changes
config/packages/_sylius.yaml
routing_path_bc_layer: false
mapping:
imports:
- "%kernel.project_dir%/src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/product.php"
Copy link
Copy Markdown
Member Author

@loic425 loic425 Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be improved later.
We'll be able to configure this path on the admin bundle itself.

@loic425 loic425 force-pushed the admin-product-crud branch from 253052e to 73797fb Compare July 16, 2025 18:10
@loic425 loic425 force-pushed the admin-product-crud branch from 73797fb to 22eb857 Compare July 17, 2025 07:14
@NoResponseMate NoResponseMate merged commit f83b09d into Sylius:new-routing Jul 17, 2025
31 checks passed
@loic425 loic425 deleted the admin-product-crud branch July 17, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees

No one assigned

Labels

Admin AdminBundle related issues and PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loic425 @NoResponseMate