src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductOptionExampleFactory.php (1)

95-97: Wrong placeholder produces labels like “Size #i1”

The format string contains #i%d; the i looks unintended and leaks into the generated value:

sprintf('%s #i%d', $options['name'], $i); // → “Size #i1”

Replace #i%d with #%d.

-                    $values[sprintf('%s-option#%d', $options['code'], $i)] = sprintf('%s #i%d', $options['name'], $i);
+                    $values[sprintf('%s-option#%d', $options['code'], $i)] = sprintf('%s #%d', $options['name'], $i);

src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAssociationTypeExampleFactory.php (1)

68-70: Drop the unused $options parameter in the first arrow function

setDefault('name', fn (Options $options): string => ...) never uses the $options argument, so keeping it is unnecessary noise. Omitting it makes the intent clearer while still satisfying OptionsResolver (it accepts callables with zero parameters).

-            ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+            ->setDefault('name', fn (): string => $this->faker->words(3, true))

src/Sylius/Bundle/CoreBundle/Fixture/Factory/ShippingMethodExampleFactory.php (1)

99-103: Avoid the unused $options parameter in the arrow function.

$options is not referenced in the closure body, so keeping it is slightly misleading and may trigger static-analysis “unused parameter” warnings. Removing it makes intent clearer and keeps the signature minimal.

-            ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+            ->setDefault('name', fn (): string => $this->faker->words(3, true))
-            ->setDefault('description', fn (Options $options): string => $this->faker->sentence())
+            ->setDefault('description', fn (): string => $this->faker->sentence())

src/Sylius/Bundle/CoreBundle/Fixture/Factory/PaymentMethodExampleFactory.php (1)

88-88: Minor: avoid the unused $options parameter in the arrow function

$options is not referenced inside the closure. You can omit the parameter altogether (Symfony’s OptionsResolver will still invoke the callable correctly) or prefix it with an underscore to silence static-analysis warnings.

- ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+ ->setDefault('name', fn (): string => $this->faker->words(3, true))

src/Sylius/Bundle/CoreBundle/Fixture/Factory/CustomerGroupExampleFactory.php (1)

55-55: Minor: drop the unused $options parameter for clarity

Because the closure doesn’t use the Options argument, you can trim it to emphasise that the default is independent of other options:

-->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+->setDefault('name', fn (): string => $this->faker->words(3, true))

(Not critical; just a readability nit.)

src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductOptionExampleFactory.php (2)

89-90: Redundant setDefault('values', …) call

setDefault('values', null) is immediately overridden by the next setDefault('values', fn …) call, so the first one has no effect and can be removed to avoid confusion.

-            ->setDefault('values', null)

---

86-87: Consider ensuring uniqueness for generated names

$this->faker->words(3, true) may yield duplicates across multiple fixture runs. If uniqueness is desirable, prefix with $this->faker->unique().

src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php (1)

72-76: Remove unused parameter in arrow function for a leaner default closure

The $options argument is never referenced inside this arrow function, so it can be safely omitted for brevity.
OptionsResolver does not require the parameter when it isn’t used.

-            ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+            ->setDefault('name', fn (): string => $this->faker->words(3, true))

src/Sylius/Bundle/CoreBundle/Fixture/Factory/ShippingCategoryExampleFactory.php (2)

58-61: Closure-type mismatch resolved; you can further streamline by removing unused parameter

Switching to an arrow function fixes the “Closure given” type error by ensuring the default is a string.
Because the $options argument is not used, you can omit it for clarity:

- ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+ ->setDefault('name', fn (): string => $this->faker->words(3, true))

---

55-61: Guard against future type regressions with explicit allowed types

The root bug slipped through because OptionsResolver accepted any value.
Adding type constraints will fail fast if a non-string (e.g. a Closure) is ever injected again:

$resolver
    ->setAllowedTypes('name', 'string')
    ->setAllowedTypes('code', 'string')
    ->setAllowedTypes('description', 'string');

src/Sylius/Bundle/CoreBundle/Fixture/Factory/ChannelExampleFactory.php (1)

113-118: Consider guaranteeing uniqueness of generated channel names

$this->faker->words(3, true) can occasionally return the same string across multiple calls, leading to duplicate channel names (and therefore duplicate codes) when a large number of fixtures are generated. Leveraging Faker’s unique() modifier removes this risk with negligible overhead:

-            ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+            ->setDefault('name', fn (Options $options): string => $this->faker->unique()->words(3, true))

src/Sylius/Bundle/CoreBundle/Fixture/Factory/TaxCategoryExampleFactory.php (1)

57-57: Unused $options parameter – replace with placeholder

The closure does not use the injected Options instance. Dropping the parameter (or renaming it to _) avoids a misleading “parameter-is-never-used” warning from static analysers.

-    ->setDefault('name', fn (Options $options): string => $this->faker->words(3, true))
+    ->setDefault('name', fn (Options $_): string => $this->faker->words(3, true))

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro