Skip to content

[Composer] Bump APIP to 4.1 and remove conflict to api-platform/json-ld#18063

Merged
mpysiak merged 1 commit intoSylius:2.1from
GSadee:SYL-4858-bump-apip-to-4.1
May 23, 2025
Merged

[Composer] Bump APIP to 4.1 and remove conflict to api-platform/json-ld#18063
mpysiak merged 1 commit intoSylius:2.1from
GSadee:SYL-4858-bump-apip-to-4.1

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented May 23, 2025 •
edited by coderabbitai bot
Loading

Q A
Branch? 2.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #17763
License MIT

Summary by CodeRabbit

  • Chores
    • Updated dependencies to require newer versions of key packages for improved compatibility.
    • Removed restrictions related to a previously conflicting package version.
    • Deleted outdated documentation regarding dependency conflicts.

@GSadee GSadee added Maintenance CI configurations, READMEs, releases, etc. API APIs related issues and PRs. Dependencies Pull requests that update a dependency file labels May 23, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented May 23, 2025 •
edited
Loading

Walkthrough

The changes update dependency version constraints for api-platform/doctrine-orm and api-platform/symfony to ^4.1.7 in two composer.json files and remove a conflict restriction with api-platform/jsonld. Additionally, the CONFLICTS.md documentation file explaining the conflict rationale is deleted.

Changes

File(s) Change Summary
composer.json, src/Sylius/Bundle/ApiBundle/composer.json Updated api-platform/doctrine-orm and api-platform/symfony requirements to ^4.1.7; removed the conflict section for api-platform/jsonld.
CONFLICTS.md Deleted documentation file explaining the composer conflict rationale.

Suggested reviewers

  • Prometee

Poem

A hop and a skip, dependencies rise,
Composer constraints now reach for the skies.
Old conflicts erased, the path is now clear,
The bundle’s refreshed, let’s all give a cheer!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b7d6d7 and 756f140.

📒 Files selected for processing (3)
  • CONFLICTS.md (0 hunks)
  • composer.json (1 hunks)
  • src/Sylius/Bundle/ApiBundle/composer.json (1 hunks)
💤 Files with no reviewable changes (1)
  • CONFLICTS.md
🔇 Additional comments (2)
src/Sylius/Bundle/ApiBundle/composer.json (1)

28-29: Bump API Platform dependencies to ^4.1.7
The version constraints for api-platform/doctrine-orm and api-platform/symfony have been updated to ^4.1.7 as intended. Please run composer update api-platform/doctrine-orm api-platform/symfony, commit the updated composer.lock, and ensure the CI suite passes with no deprecation or compatibility warnings.

composer.json (1)

34-35: Align root composer.json with API Platform ^4.1.7
The root package constraints for api-platform/doctrine-orm and api-platform/symfony match those in the ApiBundle. Ensure that the old conflict section for api-platform/jsonld has been fully removed, regenerate and commit composer.lock, and run full test coverage to catch any integration regressions.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 23, 2025 •
edited
Loading

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Check https://github.com/Sylius/Sylius/actions/runs/15204315599 for details.

Available commands:

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@GSadee GSadee marked this pull request as ready for review May 23, 2025 07:41
@GSadee GSadee requested review from a team as code owners May 23, 2025 07:41
@mpysiak mpysiak merged commit 1f09e31 into Sylius:2.1 May 23, 2025
27 checks passed
@GSadee GSadee deleted the SYL-4858-bump-apip-to-4.1 branch May 23, 2025 07:50
@coderabbitai coderabbitai bot mentioned this pull request Jul 4, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Sep 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic425 loic425 loic425 approved these changes

@mpysiak mpysiak mpysiak approved these changes

Assignees

No one assigned

Labels

API APIs related issues and PRs. Dependencies Pull requests that update a dependency file Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GSadee @loic425 @mpysiak