Skip to content

[Shop] Handle missing icon errors#17831

Merged
GSadee merged 1 commit intoSylius:2.0from
PiotrTulacz:SYL-4385/Handle-icon-error
Apr 8, 2025
Merged

[Shop] Handle missing icon errors#17831
GSadee merged 1 commit intoSylius:2.0from
PiotrTulacz:SYL-4385/Handle-icon-error

Conversation

@PiotrTulacz
Copy link
Copy Markdown

@PiotrTulacz PiotrTulacz commented Apr 4, 2025 •
edited by coderabbitai bot
Loading

Previously, when there were any issues related to icons — such as an invalid, misspelled, or missing icon name (e.g. ux_icon('tabler:brand-instagra')) — the application would throw an IconNotFoundException, resulting in a 500 error and breaking the rendering of components like the footer.

To prevent this issue:

  • Added ignore_not_found: true to the ux_icons.yaml configuration file.
  • This ensures that when an icon is missing or not found, no exception is thrown, and the icon is simply not rendered.

Benefits:
Ensures that templates using icons render properly even if some icons are unavailable

image
image

Summary by CodeRabbit

  • New Features
    • Introduced an option to bypass errors for missing icons, enhancing flexibility and reliability in icon management.

@PiotrTulacz PiotrTulacz requested review from a team as code owners April 4, 2025 10:29
@PiotrTulacz PiotrTulacz changed the base branch from 2.1 to 2.0 April 4, 2025 10:29
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new configuration option ignore_not_found has been added to the ux_icons settings in the UI bundle configuration. The option is set to true, allowing the system to bypass error handling for missing icons, thereby providing increased flexibility in managing icon availability.

Changes

Files Change Summary
src/Sylius/.../ux_icons.yaml Added new configuration option ignore_not_found: true to the ux_icons settings configuration.

Poem

I'm a little bunny with code to share,
Hopping through config with a skip in the air.
I've added a flag, so errors slide by,
Missing icons? No need to sigh.
With ears perked high, I cheer with delight,
For smooth-running code makes my day bright! 🐇

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@PiotrTulacz PiotrTulacz force-pushed the SYL-4385/Handle-icon-error branch from eb47ae9 to b6ca000 Compare April 4, 2025 11:40
@GSadee GSadee added UX Issues and PRs aimed at improving User eXperience. Bug Confirmed bugs or bugfixes. Frontend Issues and PRs related to frontend labels Apr 8, 2025
@GSadee GSadee merged commit 40fe025 into Sylius:2.0 Apr 8, 2025
24 of 27 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 9, 2025
Merged
This was referenced Nov 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSadee GSadee GSadee approved these changes

Assignees

No one assigned

Labels

Bug Confirmed bugs or bugfixes. Frontend Issues and PRs related to frontend UX Issues and PRs aimed at improving User eXperience.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PiotrTulacz @GSadee