[Behat] Reuse common setup contexts in API and UI tests, and convert unnecessary JS scenarios to non-JS by Rafikooo · Pull Request #17803 · Sylius/Sylius

Rafikooo · 2025-03-28T12:51:26Z

Q	A
Branch?	2.0
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

coderabbitai · 2025-03-28T12:51:34Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-28T13:07:55Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

features/shop/checkout/paying_for_order/paying_offline_during_checkout.feature

features/shop/promotion/applying_promotion_coupon/removing_promotion_coupon.feature

features/shop/promotion/receiving_discount/receiving_percentage_discount_on_shipping.feature

GSadee · 2025-04-10T04:49:51Z

...p/inventory/cart_inventory/ui/prevent_buying_more_products_than_available_in_a_stock.feature

@@ -0,0 +1,17 @@
+@cart_inventory
+Feature: Prevent buying more products than available in a stock


Suggested change

Feature: Prevent buying more products than available in a stock

Feature: Preventing from buying more products than available in a stock

GSadee · 2025-04-10T04:50:27Z

...s/shop/inventory/checkout_inventory/validating_product_quantity_on_checkout_complete.feature

-        And I add 5 products "2Pac T-Shirt" to the cart
-        And I proceed with selecting "Offline" payment method
+    @api @ui
+    Scenario: Prevent order confirmation if any product is unavailable in the required quantity


Suggested change

Scenario: Prevent order confirmation if any product is unavailable in the required quantity

Scenario: Preventing from order confirmation if any product is unavailable in the required quantity

…etup

…tep definitions

… removal scenarios

… steps

…ss creation

…ertion

…narios

Rafikooo requested review from a team as code owners March 28, 2025 12:51

Rafikooo changed the title ~~[Behat] Decouple cart setup from interaction – Given I added vs When I add - Continuation~~ [WIP][Behat] Decouple cart setup from interaction – Given I added vs When I add - Continuation Mar 28, 2025

Rafikooo changed the title ~~[WIP][Behat] Decouple cart setup from interaction – Given I added vs When I add - Continuation~~ [WIP][Behat] Decouple cart setup from interaction – Given I added vs When I add - Continuation Mar 28, 2025

GSadee added the Behat Issues and PRs aimed at improving Behat usage. label Mar 31, 2025

GSadee reviewed Mar 31, 2025

View reviewed changes

Rafikooo force-pushed the SYL-4567-remaining-tests branch from 814d6ac to 1a7179c Compare April 9, 2025 08:09

Rafikooo changed the title ~~[WIP][Behat] Decouple cart setup from interaction – Given I added vs When I add - Continuation~~ [WIP][Behat] Reuse common setup contexts in API and UI tests, and convert unnecessary JS scenarios to non-JS Apr 9, 2025

Rafikooo force-pushed the SYL-4567-remaining-tests branch 4 times, most recently from b3f653a to af64adb Compare April 9, 2025 22:06

GSadee previously approved these changes Apr 10, 2025

View reviewed changes

Rafikooo changed the title ~~[WIP][Behat] Reuse common setup contexts in API and UI tests, and convert unnecessary JS scenarios to non-JS~~ [Behat] Reuse common setup contexts in API and UI tests, and convert unnecessary JS scenarios to non-JS Apr 10, 2025

Rafikooo dismissed GSadee’s stale review via 9bcb7f9 April 10, 2025 07:13

Rafikooo force-pushed the SYL-4567-remaining-tests branch 2 times, most recently from 03e8d16 to 0e904ef Compare April 10, 2025 14:14

probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 10, 2025

Rafikooo force-pushed the SYL-4567-remaining-tests branch 10 times, most recently from 692a091 to 655d56c Compare April 11, 2025 09:13

Rafikooo added 26 commits April 16, 2025 15:05

[Behat] Check the validity of the image URL

75ce8cd

[Behat] Fallback to shared storage for payment and shipping methods s…

fc4131a

…etup

[Behat] Refactor checkout inventory feature with reusable checkout step

6ccf281

[Behat] Remove @javascript tag in applying promotion scenario

040467c

[Behat] Rafactor applying promotion coupon scenarios

8525390

[Behat] Refactor checkout shipping method scenarios to use reusable s…

c7a3f42

…tep definitions

[Behat] Refactor several account scenarios

c59d709

[Behat] Use consistent step definition for adding products to cart in…

e43ea92

… removal scenarios

[API] Make address-related assertion messages more informative

fb09ad1

[Behat] Add new address factory methods

c7a23e0

[Behat] Refactor chckout summary scenarios to use new address context…

c1c6f2c

… steps

[Behat] Fix address factory by setting province to ensure valid addre…

ef4f072

…ss creation

[Behat] Add explicit product reference to subtotal price decrease ass…

fe458c2

…ertion

[Behat] Harmonize step definitions and tags across checkout scenarios

4c7c782

[Behat] Fix applying taxes in checkout scenario

2ec636b

[Behat][Admin] Remove unnecessary js tag

8505a0c

[Behat] Extract end-to-end shopping cart scenarios

056f52b

[Behat] Extract pure UI shopping cart scenarios

eeac175

[Behat] Remove JS tags from domain-oriented shopping cart scenarios

62851f5

[Behat] Implement setup steps for changing and removing items from cart

79c1d1c

[Behat] Extract end-to-end promotion scenarios

0baa004

[Behat] Remove JS tags from domain-oriented promotion scenarios

c33fc11

[Behat] Remove JS tags from domain-specific shipping and taxation sce…

50885e8

…narios

[Behat] Refactor shop inventory scenarios

c333aee

[API] Refactor OrderPromotionCodeAssigner class

5904692

[CI] Improve readability of Behat command

df46998

Rafikooo force-pushed the SYL-4567-remaining-tests branch from 0383c57 to df46998 Compare April 16, 2025 13:05

TheMilek approved these changes Apr 16, 2025

View reviewed changes

GSadee approved these changes Apr 16, 2025

View reviewed changes

GSadee merged commit aaccc0c into Sylius:2.0 Apr 16, 2025
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Behat] Reuse common setup contexts in API and UI tests, and convert unnecessary JS scenarios to non-JS#17803

[Behat] Reuse common setup contexts in API and UI tests, and convert unnecessary JS scenarios to non-JS#17803
GSadee merged 26 commits intoSylius:2.0from
Rafikooo:SYL-4567-remaining-tests

Rafikooo commented Mar 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GSadee Apr 10, 2025

Uh oh!

GSadee Apr 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,17 @@
		@cart_inventory
		Feature: Prevent buying more products than available in a stock

	Feature: Prevent buying more products than available in a stock
	Feature: Preventing from buying more products than available in a stock

	Scenario: Prevent order confirmation if any product is unavailable in the required quantity
	Scenario: Preventing from order confirmation if any product is unavailable in the required quantity

Uh oh!

Conversation

Rafikooo commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GSadee Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

GSadee Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rafikooo commented Mar 28, 2025 •

edited

Loading

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 28, 2025 •

edited

Loading