Skip to content

[2.0][Admin][FIX] Use a unique id for each tab group#17752

Merged
GSadee merged 5 commits intoSylius:2.0from
nicolalazzaro:issue_17747
Apr 23, 2025
Merged

[2.0][Admin][FIX] Use a unique id for each tab group#17752
GSadee merged 5 commits intoSylius:2.0from
nicolalazzaro:issue_17747

Conversation

@nicolalazzaro
Copy link
Copy Markdown
Contributor

@nicolalazzaro nicolalazzaro commented Mar 14, 2025 •
edited by coderabbitai bot
Loading

Q A
Branch? 2.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #17747
License MIT

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced tab navigation to ensure each tab and its associated content area have unique identifiers, reducing potential conflicts and improving interface reliability.

@nicolalazzaro nicolalazzaro requested review from a team as code owners March 14, 2025 16:37
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Mar 14, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a new variable, tab_id, which is constructed by concatenating channel_code with id to create unique identifiers for each tab in the sylius_channel_collection_row block. The href attributes of the anchor tags and the id attributes of the tab panes have been updated to use tab_id instead of the previous direct use of channel_code. Additionally, the calls to the sylius_test_html_attribute function have been modified to reference tab_id instead of channel_code.

Changes

File(s) Change Summary
src/Sylius/Bundle/AdminBundle/templates/shared/form_theme.html.twig Introduced tab_id to generate unique identifiers by concatenating channel_code with id; updated attributes (href, id) and test function calls accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant T as Template Engine
    participant F as Form Renderer

    T->>F: For each channel element
    F->>T: Generate tab_id (channel_code + id)
    F->>F: Set tab anchor's href using tab_id
    F->>F: Set tab pane's id using tab_id
    F->>F: Update sylius_test_html_attribute with tab_id
Loading

Assessment against linked issues

Objective Addressed Explanation
Unique identifiers for variant tabs to allow independent switching (17747) ✅

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

Wojdylak
Wojdylak reviewed Apr 11, 2025
View reviewed changes
@nicolalazzaro nicolalazzaro requested a review from Wojdylak April 14, 2025 08:42
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 23, 2025
@Wojdylak Wojdylak changed the base branch from 2.1 to 2.0 April 23, 2025 06:25
Wojdylak
Wojdylak previously approved these changes Apr 23, 2025
View reviewed changes
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Apr 23, 2025
@GSadee GSadee merged commit c618739 into Sylius:2.0 Apr 23, 2025
27 checks passed
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Apr 23, 2025

Thank you @nicolalazzaro and @Wojdylak! 🎉

@coderabbitai coderabbitai bot mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSadee GSadee GSadee approved these changes

@Wojdylak Wojdylak Wojdylak left review comments

Assignees

No one assigned

Labels

Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[2.0][Admin] Variant generate with multiple channel

3 participants

@nicolalazzaro @GSadee @Wojdylak