[APIP] Formatting values (FILTER_SANITIZE_URL) by christopherhero · Pull Request #17728 · Sylius/Sylius

christopherhero · 2025-03-10T19:49:38Z

resolves #17727

The problem occurs in all API commands that implement Sylius\Bundle\ApiBundle\Command\IriToIdentifierConversionAwareInterface.

Q	A
Branch?	1.13, 1.14 and 2.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #17727
License	MIT

coderabbitai · 2025-03-10T19:49:49Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-10T19:50:30Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

src/Sylius/Bundle/ApiBundle/Converter/IriToIdentifierConverter.php

diimpp · 2025-03-25T11:53:24Z

src/Sylius/Bundle/ApiBundle/Converter/IriToIdentifierConverter.php

            return false;
        }

+        $fieldValue = filter_var($fieldValue, FILTER_SANITIZE_URL);


As far as I understand, it will only cleanup field data for IRI conversion and full comment (from example) will go into DB?

Sanitize option doesn't do validation and always will return what have been supplied (int, invalid url strings), but my only concern is support for non-latin paths.

Sanitize the string by remove all characters except latin letters

https://www.php.net/manual/en/filter.constants.php#constant.filter-sanitize-url

As far as I understand, it will only cleanup field data for IRI conversion and full comment (from example) will go into DB?

yes exactly.

Sanitize option doesn't do validation and always will return what have been supplied (int, invalid url strings), but my only concern is support for non-latin paths.

Could you please give an example of what url's you mean ?

@diimpp
I added test coverage*

NoResponseMate · 2025-04-18T11:42:47Z

Hi @christopherhero,

Any update regarding this PR?

Cheers 🍻

…ndle\Converter\IriToIdentifierConverter::isIdentifier($fieldValue)` (fix after -> symfony/http-foundation@168b77c71)

christopherhero · 2025-04-22T13:13:44Z

Hi @christopherhero,

Any update regarding this PR?

Cheers 🍻

Hi, @NoResponseMate
I just added coverage in testing. ;)

…ted to url validation

GSadee · 2025-05-06T11:33:27Z

Thank you @christopherhero! 🎉

christopherhero requested a review from a team as a code owner March 10, 2025 19:49

probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Mar 10, 2025

christopherhero closed this Mar 10, 2025

christopherhero force-pushed the fix/identifier_converter branch from 30b2e04 to d0ee4e1 Compare March 10, 2025 19:52

christopherhero reopened this Mar 10, 2025

probot-autolabeler bot added the API APIs related issues and PRs. label Mar 10, 2025

christopherhero removed Maintenance CI configurations, READMEs, releases, etc. Docker Docker-related issues and PRs. labels Mar 10, 2025

christopherhero requested a review from a team March 11, 2025 10:13

GSadee changed the base branch from 1.13 to 1.14 March 11, 2025 11:29

christopherhero force-pushed the fix/identifier_converter branch from 8870a2f to ce59fe5 Compare March 11, 2025 11:44

mpysiak previously approved these changes Mar 11, 2025

View reviewed changes

christopherhero linked an issue Mar 11, 2025 that may be closed by this pull request

[API] Endpoint to add review does not accept newline characters in the body #17727

Closed

christopherhero requested a review from a team March 18, 2025 10:46

Wojdylak previously approved these changes Mar 25, 2025

View reviewed changes

NoResponseMate reviewed Mar 25, 2025

View reviewed changes

src/Sylius/Bundle/ApiBundle/Converter/IriToIdentifierConverter.php Outdated Show resolved Hide resolved

diimpp reviewed Mar 25, 2025

View reviewed changes

NoResponseMate assigned christopherhero Apr 18, 2025

[APIP] Formatting values (FILTER_SANITIZE_URL) in `SyliusBundle\ApiBu…

c76b823

…ndle\Converter\IriToIdentifierConverter::isIdentifier($fieldValue)` (fix after -> symfony/http-foundation@168b77c71)

christopherhero dismissed stale reviews from Wojdylak and mpysiak via 2ae2a47 April 22, 2025 13:17

christopherhero force-pushed the fix/identifier_converter branch from ce59fe5 to 2ae2a47 Compare April 22, 2025 13:17

probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Apr 22, 2025

christopherhero changed the base branch from 1.14 to 2.0 April 22, 2025 14:48

christopherhero force-pushed the fix/identifier_converter branch from 2ae2a47 to e9e539d Compare April 23, 2025 12:48

Add scenarios to IriToIdentifierConverterTest to cover changes rela…

aa52620

…ted to url validation

christopherhero force-pushed the fix/identifier_converter branch from e9e539d to aa52620 Compare April 23, 2025 12:55

christopherhero requested review from NoResponseMate, Wojdylak, diimpp and mpysiak April 23, 2025 12:55

GSadee approved these changes May 6, 2025

View reviewed changes

GSadee merged commit 6077335 into Sylius:2.0 May 6, 2025
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[APIP] Formatting values (FILTER_SANITIZE_URL) #17728

[APIP] Formatting values (FILTER_SANITIZE_URL) #17728
GSadee merged 2 commits intoSylius:2.0from
christopherhero:fix/identifier_converter

christopherhero commented Mar 10, 2025 •

edited by Prometee

Loading

Uh oh!

coderabbitai bot commented Mar 10, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

diimpp Mar 25, 2025

Uh oh!

christopherhero Apr 22, 2025 •

edited

Loading

Uh oh!

christopherhero Apr 22, 2025

Uh oh!

NoResponseMate commented Apr 18, 2025

Uh oh!

christopherhero commented Apr 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

GSadee commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

christopherhero commented Mar 10, 2025 • edited by Prometee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Uh oh!

diimpp Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

christopherhero Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherhero Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

NoResponseMate commented Apr 18, 2025

Uh oh!

christopherhero commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

GSadee commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

christopherhero commented Mar 10, 2025 •

edited by Prometee

Loading

coderabbitai bot commented Mar 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 10, 2025 •

edited

Loading

christopherhero Apr 22, 2025 •

edited

Loading

christopherhero commented Apr 22, 2025 •

edited

Loading