[UI] Refix invalid key setting on adding a collection item#17723
Merged
GSadee merged 2 commits intoSylius:2.0from Mar 7, 2025
Merged
[UI] Refix invalid key setting on adding a collection item#17723GSadee merged 2 commits intoSylius:2.0from
GSadee merged 2 commits intoSylius:2.0from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❗ Preview Environment delete from Bunnyshell failedCheck https://github.com/Sylius/Sylius/actions/runs/13718075396 for details. See: Environment Details Available commands:
|
Wojdylak
approved these changes
Mar 6, 2025
mpysiak
approved these changes
Mar 7, 2025
GSadee
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for collection items being substituted when removing an item from anywhere but the end of the collection and adding a new item has inadvertently caused a different bug to prop up, breaking the adding of multiple select product attributes due to their collection keys not being comparable.
Curiously, we have an UI test for this exact case, but it seems to just ignore the exception popup and continue with other steps; Updated to check the saved values so we can be sure of the outcome.