Skip to content

Fix autocomplete styles#17710

Merged
GSadee merged 1 commit intoSylius:2.0from
bartek-sek:shop-autocomplete-fix
Mar 3, 2025
Merged

Fix autocomplete styles#17710
GSadee merged 1 commit intoSylius:2.0from
bartek-sek:shop-autocomplete-fix

Conversation

@bartek-sek
Copy link
Copy Markdown
Contributor

@bartek-sek bartek-sek commented Mar 3, 2025 •
edited by coderabbitai bot
Loading

Q A
Branch? 2.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Summary by CodeRabbit

  • Style
    • Introduced enhanced custom styling for a select component, improving its visual appearance and interactive feedback.
    • Updated the styling integration by shifting from a Bootstrap-specific setup to a more general configuration, ensuring consistent theming across the interface.

@bartek-sek bartek-sek requested review from a team as code owners March 3, 2025 09:21
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Mar 3, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 3, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new SCSS file is added to define custom styles for the Tom Select component, detailing various states such as focus and dropdown presentations. The main SCSS file is also updated by removing a Bootstrap 5 specific import and adding a generic import for Tom Select. These changes adjust the visual styling of the select component throughout the application.

Changes

File(s) Summary
src/Sylius/Bundle/ShopBundle/.../_tom-select.scss Added new SCSS file with custom styles for Tom Select, including styling for control elements, dropdowns, and clear buttons.
src/Sylius/Bundle/ShopBundle/.../main.scss Removed the Bootstrap 5 specific import for Tom Select and replaced it with a generic import.

Suggested labels

UX, Admin

Suggested reviewers

  • Wojdylak
  • mpysiak
  • GSadee

Poem

I'm a bouncy bunny, coding away,
Hopping through SCSS in a delightful display.
Tom Select now sparkles with styles so neat,
And our main file’s update makes it complete.
With a skip and a hop, I celebrate the change,
Happy coding from my rabbit range!
🥕🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025 •
edited
Loading

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
mailhog https://mailhog-xjewcw.bunnyenv.com/
php https://store-xjewcw.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands:

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@GSadee GSadee changed the base branch from 2.1 to 2.0 March 3, 2025 09:58
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Mar 3, 2025

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "shop-autocomplete-fix" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee force-pushed the shop-autocomplete-fix branch from 18e9d33 to eaca325 Compare March 3, 2025 09:58
@GSadee GSadee added the UX Issues and PRs aimed at improving User eXperience. label Mar 3, 2025
@GSadee GSadee merged commit 5a5fddb into Sylius:2.0 Mar 3, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSadee GSadee GSadee approved these changes

Assignees

No one assigned

Labels

Shop ShopBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartek-sek @GSadee