[PoC] Resource operations by loic425 · Pull Request #17695 · Sylius/Sylius

loic425 · 2025-02-26T08:49:10Z

Q	A
Branch?	2.1
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets
License	MIT

Linked to Sylius/SyliusResourceBundle#983

coderabbitai · 2025-02-26T08:49:17Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

loic425 · 2025-02-26T08:51:07Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/config.yml

+sylius_resource:
+    mapping:
+        imports:
+            - "%kernel.project_dir%/src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources"


Of course, this needs to be fixed.
It should be @SyliusAdminBundle/Resources/config/app/sylius/resources

We should also configure this on another config file to provide a bc-layer.
Routes will still be built with ResourceController system by default on 2.x and should be removed on 3.x.

config/routes/sylius_resource.yaml

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/zone.php

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/inventory.php

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/payment.php

github-actions · 2025-03-03T09:47:23Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

loic425 · 2025-06-30T11:52:19Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/product_taxon.php

+use Sylius\Resource\Metadata\Operations;
+use Sylius\Resource\Metadata\ResourceMetadata;
+
+return (new ResourceMetadata())


This one has a small issue on the browser title.

.github/workflows/ci_e2e-mariadb.yaml

loic425 · 2025-07-01T14:51:54Z

src/Sylius/Behat/Context/Ui/Admin/ManagingProductVariantsContext.php

+        try {
+            $this->indexPage->deleteResourceOnPage(['code' => $productVariant->getCode()]);
+        } catch (ResourceDeleteException $exception) {
+            $this->sharedStorage->set('last_exception', $exception);


The error message is still ok.

features/admin/order/managing_orders/handling_order_payment/finalizing_order_payment.feature

loic425 · 2025-07-04T09:44:03Z

src/Sylius/Behat/Context/Ui/Admin/ManagingPromotionCouponsContext.php

        private readonly UpdatePageInterface $updatePage,
        private readonly FormElementInterface $formElement,
        private readonly NotificationCheckerInterface $notificationChecker,
+        private SharedStorageInterface $sharedStorage,


Suggested change

private SharedStorageInterface $sharedStorage,

private readonly SharedStorageInterface $sharedStorage,

Prometee · 2025-07-04T10:00:23Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/admin_user.php

+use Sylius\Resource\Metadata\Update;
+
+return (new ResourceMetadata())
+    ->withRoutePrefix('/admin')


Use the parameter instead:

Suggested change

->withRoutePrefix('/admin')

->withRoutePrefix('/%sylius_admin.path_name%')

Same for every admin resource definition.

Prometee · 2025-07-04T10:02:54Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/admin_user.php

+    ->withRoutePrefix('/admin')
+    ->withClass('%sylius.model.admin_user.class%')
+    ->withSection('admin')
+    ->withTemplatesDir('@SyliusAdmin\\shared\\crud')


I see this a lot but Symfony can handle both / and \ format.

To avoid using too many chars this can be simplified like this:

Suggested change

->withTemplatesDir('@SyliusAdmin\\shared\\crud')

->withTemplatesDir('@SyliusAdmin/shared/crud')

Same for the rest of the resource definitions

Yes, I agree.

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/admin_user.php

Prometee · 2025-07-04T10:14:28Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/admin_user.php

+return (new ResourceMetadata())
+    ->withRoutePrefix('/admin')
+    ->withClass('%sylius.model.admin_user.class%')
+    ->withSection('admin')


💡 This can be transform to a class constant or a parameter one day

Could also somehow be joined w/ the SectionInterface objects. That'd probably necessitate moving the interface to ResourceBundle, but ultimately should ease resolving and basing some logic on specific sections.
Food for thought.

Prometee · 2025-07-04T10:33:24Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/product.php

+            formType: ProductGenerateVariantsType::class,
+            notificationMessage: 'sylius.product_variant.generate',
+            redirectToRoute: 'sylius_admin_product_variant_index',
+            redirectArguments: ['productId' => "request.attributes.get('productId')"],


There is a notation used to specify that the value has to be interpreted, why in this case we are not using :

Suggested change

redirectArguments: ['productId' => "request.attributes.get('productId')"],

redirectArguments: ['productId' => "@=request.attributes.get('productId')"],

currently here, we can only have an expression.
So, we need to

allow this extra characters like you did here..

deprecate using expresion without using "@="

allow simple strings

Prometee · 2025-07-04T10:35:07Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/taxon.php

+        new Create(redirectToRoute: 'sylius_admin_taxon_update'),
+        new Create(
+            path: 'taxons/new/{id}',
+            template: '@SyliusAdmin/shared/crud/create.html.twig',


If the resource use : @SyliusAdmin/shared/crud as templateDir is this template required ?

I need to check that one. I think it uses the short name of the operation.

Prometee · 2025-07-04T10:36:55Z

src/Sylius/Bundle/AdminBundle/Resources/config/routing/admin_user.yml

+#sylius_admin_admin_user:
+#    resource: |
+#        alias: sylius.admin_user
+#        section: admin
+#        path: users
+#        templates: "@SyliusAdmin\\shared\\crud"
+#        except: ['show']
+#        redirect: index
+#        grid: sylius_admin_admin_user
+#        form:
+#            type: Sylius\Bundle\AdminBundle\Form\Type\AdminUserType
+#        permission: true
+#    type: sylius.resource


Can we move all route resource to a dedicated file, so we can migrate resources one by one?

I think we cannot move routing files. The file is public, so we can break things.
I need to test routing condition to bring a bc-layer with that kind of thing
https://github.com/monsieurbiz/SyliusCmsPagePlugin/blob/8cc79bf5e0a3b66799868ad4ff7e13086f80b347/src/Routing/RequestContext.php#L42

loic425 · 2025-10-28T09:32:20Z

I think everything from that PoC have been used in related PRs.

loic425 requested review from a team as code owners February 26, 2025 08:49

probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Feb 26, 2025

loic425 marked this pull request as draft February 26, 2025 08:49

loic425 commented Feb 26, 2025

View reviewed changes

config/routes/sylius_resource.yaml Outdated Show resolved Hide resolved

loic425 commented Feb 26, 2025

View reviewed changes

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/zone.php Outdated Show resolved Hide resolved

loic425 commented Feb 26, 2025

View reviewed changes

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/inventory.php Outdated Show resolved Hide resolved

loic425 self-assigned this Feb 26, 2025

loic425 force-pushed the poc/resource-operations branch from b25573c to a365750 Compare February 27, 2025 13:35

loic425 commented Feb 27, 2025

View reviewed changes

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/payment.php Outdated Show resolved Hide resolved

loic425 commented Feb 27, 2025

View reviewed changes

src/Sylius/Bundle/AdminBundle/Resources/config/app/sylius/resources/payment.php Outdated Show resolved Hide resolved

loic425 force-pushed the poc/resource-operations branch 2 times, most recently from 6723998 to d81a730 Compare March 3, 2025 09:45

loic425 force-pushed the poc/resource-operations branch from d81a730 to c742165 Compare June 10, 2025 15:24

loic425 force-pushed the poc/resource-operations branch 2 times, most recently from 90988a1 to 7814307 Compare June 18, 2025 07:08

loic425 force-pushed the poc/resource-operations branch from 7814307 to 694f23e Compare June 30, 2025 11:48

loic425 commented Jun 30, 2025

View reviewed changes

loic425 force-pushed the poc/resource-operations branch 4 times, most recently from de977b6 to 1655d6b Compare June 30, 2025 14:43

probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 30, 2025

loic425 commented Jun 30, 2025

View reviewed changes

.github/workflows/ci_e2e-mariadb.yaml Outdated Show resolved Hide resolved

loic425 force-pushed the poc/resource-operations branch 3 times, most recently from c1d3124 to 89075d5 Compare July 1, 2025 10:07

loic425 commented Jul 1, 2025

View reviewed changes

loic425 force-pushed the poc/resource-operations branch 4 times, most recently from efb4fe7 to 5f37500 Compare July 2, 2025 08:14

loic425 commented Jul 4, 2025

View reviewed changes

features/admin/order/managing_orders/handling_order_payment/finalizing_order_payment.feature Outdated Show resolved Hide resolved

loic425 commented Jul 4, 2025

View reviewed changes

Prometee requested changes Jul 4, 2025

View reviewed changes

loic425 force-pushed the poc/resource-operations branch 3 times, most recently from 4eeac1b to c75eba4 Compare July 7, 2025 09:46

[PoC] Resource operations

8fd5c47

loic425 force-pushed the poc/resource-operations branch from c75eba4 to 8fd5c47 Compare July 7, 2025 12:32

loic425 mentioned this pull request Jul 7, 2025

Using new routing system from Sylius resource bundle #18212

Open

loic425 closed this Oct 28, 2025

	private SharedStorageInterface $sharedStorage,
	private readonly SharedStorageInterface $sharedStorage,

	->withRoutePrefix('/admin')
	->withRoutePrefix('/%sylius_admin.path_name%')

	->withTemplatesDir('@SyliusAdmin\\shared\\crud')
	->withTemplatesDir('@SyliusAdmin/shared/crud')

	redirectArguments: ['productId' => "request.attributes.get('productId')"],
	redirectArguments: ['productId' => "@=request.attributes.get('productId')"],

Uh oh!

Conversation

loic425 commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

loic425 Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic425 Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic425 Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic425 commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

loic425 commented Feb 26, 2025 •

edited

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

loic425 Feb 26, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025 •

edited

Loading

loic425 Jul 4, 2025 •

edited

Loading

loic425 Jul 4, 2025 •

edited

Loading