[Admin] Fix taxon deletion by Wojdylak · Pull Request #17666 · Sylius/Sylius

Wojdylak · 2025-02-11T10:10:51Z

Q	A
Branch?	2.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	#17650
License	MIT

Summary by CodeRabbit

Bug Fixes
- Improved modal alignment and behavior: The modal now attaches to a more suitable container, ensuring a consistent layout and positioning within the interface. Users will experience a steadier visual arrangement when interacting with modal dialogs, leading to an improved overall user interface aesthetic.

coderabbitai · 2025-02-11T10:11:00Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The change updates the JavaScript controller managing taxon deletion in the admin UI. The modal element is now appended to the closest element with the .btn-group class instead of .dropdown, modifying its placement and potential behavior in the UI. There are no modifications to event handling or public declarations.

Changes

File Path	Summary
src/Sylius/Bundle/AdminBundle/Resources/assets/controllers/DeleteTaxonController.js	Changed modal append target from `.dropdown` to `.btn-group`

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Controller as DeleteTaxonController
    participant DOM as Document Object Model
    User->>Controller: Click Delete Taxon button
    Controller->>DOM: Find closest '.btn-group'
    DOM-->>Controller: Return container element
    Controller->>DOM: Append modal element to container
    Controller->>Controller: Initialize modal events

Possibly related issues

[2.0][Admin] Can't delete taxon from the UI #17650: Changing the append target to .btn-group directly addresses the reported JavaScript error preventing taxon deletion in the admin panel.

Suggested reviewers

GSadee
mpysiak

Poem

I'm the rabbit, quick and bright,
Hopping through code with delight.
Modal finds a btn-group home,
No longer lost in a dropdown dome.
Happy coding, in every byte! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-11T10:23:44Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

src/Sylius/Bundle/AdminBundle/Resources/assets/controllers/DeleteTaxonController.js

[Admin] Fix taxon deletion

03547ce

Wojdylak requested review from a team as code owners February 11, 2025 10:10

probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Feb 11, 2025

mpysiak previously approved these changes Feb 11, 2025

View reviewed changes

NoResponseMate reviewed Feb 11, 2025

View reviewed changes

src/Sylius/Bundle/AdminBundle/Resources/assets/controllers/DeleteTaxonController.js Outdated Show resolved Hide resolved

[Admin][Taxon] Use custom attribute

c7ae974

Wojdylak dismissed mpysiak’s stale review via c7ae974 February 24, 2025 09:50

NoResponseMate approved these changes Feb 24, 2025

View reviewed changes

GSadee approved these changes Feb 25, 2025

View reviewed changes

GSadee merged commit 1b82fc2 into Sylius:2.0 Feb 25, 2025
27 checks passed

GSadee mentioned this pull request Feb 25, 2025

[2.0][Admin] Can't delete taxon from the UI #17650

Closed

Wojdylak deleted the admin-fix-deleting-taxon branch March 21, 2025 20:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Admin] Fix taxon deletion#17666

[Admin] Fix taxon deletion#17666
GSadee merged 2 commits intoSylius:2.0from
Wojdylak:admin-fix-deleting-taxon

Wojdylak commented Feb 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Feb 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Wojdylak commented Feb 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Possibly related issues

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Wojdylak commented Feb 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Feb 11, 2025 •

edited

Loading