SYL-4221: Fix taxon tree styles by bartek-sek · Pull Request #17589 · Sylius/Sylius

bartek-sek · 2024-12-20T12:20:59Z

Product taxonomy

Changed pointer icons and hover cursor for clickable elements.
Before:

After:

Taxons

Changed pointer icons.
Before:

After:

Summary by CodeRabbit

New Features
- Enhanced hover effects for the infinite tree component, improving interactivity.
- Updated SVG icon for the toggler with improved visibility.
Bug Fixes
- Simplified transformations for the toggler's icon, enhancing clarity.

coderabbitai · 2024-12-20T12:21:06Z

Walkthrough

The pull request introduces styling modifications to the infinite tree component in the _infinite-tree.scss file. The changes focus on enhancing the visual interaction and appearance of tree togglers and checkboxes. Specifically, new hover effects have been implemented for the .infinite-tree-toggler and .infinite-tree-check classes, updating cursor styles, icon opacity, and pseudo-element transformations to improve the component's user experience and visual clarity.

Changes

File	Change Summary
`src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_infinite-tree.scss`	- Updated hover effects for `.infinite-tree-toggler` - Modified SVG icon for toggler's pseudo-element - Increased icon opacity from 0.3 to 0.5 - Simplified transformation for `.infinite-tree-closed` - Added hover effect for `.infinite-tree-check`

Possibly related PRs

General UI improvements #2 #17576: UI improvements in _sidebar.scss file, potentially related to similar visual interaction enhancements

Suggested reviewers

Wojdylak

Poem

🌳 In the realm of infinite trees, where branches sway,
A rabbit's CSS dance makes icons play!
Hover and click, with pointers so bright,
Transforming styles with pixel-perfect might! 🐰✨

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_infinite-tree.scss (1)
49-54: Consider optimizing the SVG viewBox dimensions

The SVG has a viewBox of 24x24 but is displayed at 16x16 pixels. This mismatch might cause slight blur or rendering inconsistencies.

Consider updating the SVG to match the display dimensions:
-    content: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" viewBox="0 0 24 24"><path fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="m6 9l6 6l6-6"/></svg>');
+    content: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"><path fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.5" d="m4 6l4 4l4-4"/></svg>');

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd339a5 and 7deac11.

📒 Files selected for processing (1)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_infinite-tree.scss (2 hunks)

🔇 Additional comments (3)

src/Sylius/Bundle/AdminBundle/Resources/assets/styles/_infinite-tree.scss (3)

40-45: LGTM: Improved user interaction feedback

The addition of the pointer cursor on hover properly indicates the interactive nature of the toggler buttons.

58-58: LGTM: Clean transform implementation

The simplified transform properly handles the icon rotation for the closed state.

75-78: LGTM: Enhanced checkbox interaction

The addition of the pointer cursor on checkbox hover improves user interaction feedback.

github-actions · 2024-12-20T12:45:46Z

Bunnyshell Preview Environment deleted

Available commands:

/bns:deploy to redeploy the environment

I would like to see what it looked like before and after

Fix taxon tree styles

7deac11

bartek-sek requested review from a team as code owners December 20, 2024 12:21

probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Dec 20, 2024

coderabbitai bot reviewed Dec 20, 2024

View reviewed changes

Wojdylak approved these changes Dec 30, 2024

View reviewed changes

mpysiak approved these changes Jan 7, 2025

View reviewed changes

GSadee added the UX Issues and PRs aimed at improving User eXperience. label Jan 10, 2025

GSadee previously approved these changes Jan 10, 2025

View reviewed changes

GSadee approved these changes Jan 10, 2025

View reviewed changes

GSadee merged commit b73262b into Sylius:2.0 Jan 10, 2025

This was referenced Jan 10, 2025

SYL-4224: UI improvements #17597

Merged

[Admin] Improve product grid layout and main taxon display #17618

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SYL-4221: Fix taxon tree styles#17589

SYL-4221: Fix taxon tree styles#17589
GSadee merged 1 commit intoSylius:2.0from
bartek-sek:SYL-4221/taxon-tree

bartek-sek commented Dec 20, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 20, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

bartek-sek commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Product taxonomy

Taxons

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bunnyshell Preview Environment deleted

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bartek-sek commented Dec 20, 2024 •

edited

Loading

coderabbitai bot commented Dec 20, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Dec 20, 2024 •

edited

Loading