PHP 8.0 syntax in Core Bundle#13565
Merged
lchrusciel merged 3 commits intoSylius:1.11from Feb 4, 2022
Merged
Conversation
Contributor
Zales0123
commented
Jan 31, 2022
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | extracted from #13562 for better readability |
| License | MIT |
fd8729b to
0350ae5
Compare
b3c5410 to
160361f
Compare
lchrusciel
approved these changes
Feb 4, 2022
src/Sylius/Bundle/CoreBundle/Fixture/Factory/AdminUserExampleFactory.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/Factory/CatalogPromotionExampleFactory.php
Outdated
Show resolved
Hide resolved
| @@ -99,7 +89,7 @@ protected function configureOptions(OptionsResolver $resolver): void | |||
| ->setNormalizer( | |||
| 'birthday', | |||
| /** @param string|\DateTimeInterface|null $value */ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| /** @param string|\DateTimeInterface|null $value */ |
| string $dataClass, | ||
| array $validationGroups, | ||
| ?RepositoryInterface $channelPricingRepository = null | ||
| private ?\Sylius\Component\Resource\Repository\RepositoryInterface $channelPricingRepository = null |
Contributor
There was a problem hiding this comment.
Suggested change
| private ?\Sylius\Component\Resource\Repository\RepositoryInterface $channelPricingRepository = null | |
| private ?RepositoryInterface $channelPricingRepository = null |
| $this->session = $session; | ||
| public function __construct( | ||
| private SessionInterface $session, | ||
| string $firewallContextName, |
Contributor
There was a problem hiding this comment.
Suggested change
| string $firewallContextName, | |
| private string $firewallContextName, |
| private EventDispatcherInterface $eventDispatcher | ||
| ) { | ||
| $this->sessionTokenParameter = sprintf('_security_%s', $firewallContextName); | ||
| $this->firewallContextName = $firewallContextName; |
Contributor
There was a problem hiding this comment.
Suggested change
| $this->firewallContextName = $firewallContextName; |
Comment on lines
27
to
28
| private string $firewallContextName; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| private string $firewallContextName; |
Contributor
|
Thanks, Mateusz! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.