Skip to content

Use PHP 7.4 syntax#249

Merged
Zales0123 merged 5 commits intoSylius:masterfrom
GSadee:php-7.4-syntax
Sep 16, 2021
Merged

Use PHP 7.4 syntax#249
Zales0123 merged 5 commits intoSylius:masterfrom
GSadee:php-7.4-syntax

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented Sep 6, 2021

Related to Sylius/Sylius#12891

@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Sep 6, 2021
@GSadee GSadee requested a review from a team as a code owner September 6, 2021 11:14
@GSadee GSadee mentioned this pull request Sep 6, 2021
10 tasks

/** @var ShowPageInterface */
private $showPage;
private \Tests\Sylius\InvoicingPlugin\Behat\Page\Admin\Invoice\ShowPageInterface $showPage;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be just ShowPageInterface

@Zales0123 Zales0123 merged commit e3457ca into Sylius:master Sep 16, 2021
@Zales0123
Copy link
Copy Markdown
Contributor

Thanks, Grzegorz! 🥇

@GSadee GSadee deleted the php-7.4-syntax branch September 16, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants