Swift 5 and Xcode 10.2 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mdiep
approved these changes
Apr 12, 2019
Contributor
|
Thanks! This looks great. |
This was referenced Apr 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the project and its dependencies to build with Swift 5 and Xcode 10.2.
This PR is built on top of #145, which updates the project to Swift 4.2.
I kept the changes as minimal as possible to get the project building with the latest Swift and Xcode, but following this PR there are several other improvements that can be made:
Resulttype.EquatableandHashableimplementations where the compiler-synthesized versions are satisfactory.