Skip to content

Update to Stencil 0.7#219

Merged
djbe merged 3 commits intoSwiftGen:masterfrom
kylef:kylef/stencil-0.7
Dec 3, 2016
Merged

Update to Stencil 0.7#219
djbe merged 3 commits intoSwiftGen:masterfrom
kylef:kylef/stencil-0.7

Conversation

@kylef
Copy link
Copy Markdown
Collaborator

@kylef kylef commented Dec 1, 2016

Closes #217

I noticed you're using a beta version of CocoaPods that I'm not, please feel free to pull down my PR and run pod install on a different version if you'd rather that didn't change.

@kylef kylef mentioned this pull request Dec 1, 2016
@kylef
Copy link
Copy Markdown
Collaborator Author

kylef commented Dec 1, 2016

This should be good to go now, looks like Travis CI has a large backlog.

Copy link
Copy Markdown
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this needs a rebase though?

Also don't forget to add an entry in the CHANGELOG 😉

@djbe
Copy link
Copy Markdown
Member

djbe commented Dec 1, 2016

@kylef I'll also do a pod install like you suggested, to minimise the diff (after your rebase).

@kylef
Copy link
Copy Markdown
Collaborator Author

kylef commented Dec 1, 2016

I've updated this PR with the following:

  • Rebased onto current master.
  • Switched to same version of CocoaPods as master.
  • Added changelog item.
  • Updated SwiftGen template documentation to refer to new Stencil documentation website.

CHANGELOG.md Outdated
* Strings dot-syntax template: use `enum`s for namespacing instead of `struct`s.
[David Jennes](https://github.com/djbe)
[#218](https://github.com/AliSoftware/SwiftGen/pull/218)
* Updated Stencil to [0.7](https://github.com/kylef/Stencil/releases/tag/0.7.0).
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you actually updated to 0.7.2 😉

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although 0.7 includes 0.7.0, 0.7.1, 0.7.2 😉.

I think it's better to link to 0.7 changelog because 0.7.1 and 0.7.2 do not include changes that will affect any user of SwiftGen. These two releases only include bug fixes for problems in 0.7.

@plivesey
Copy link
Copy Markdown

plivesey commented Dec 2, 2016

Nice @kylef. Commenting so I get an email when it's merged.

@djbe djbe added this to the Next patch (4.0.1) milestone Dec 3, 2016
@djbe djbe merged commit 3339de3 into SwiftGen:master Dec 3, 2016
@kylef kylef deleted the kylef/stencil-0.7 branch December 3, 2016 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants