Templates for Swift 3 Compliant with API Design Guidelines#194
Merged
dostrander merged 4 commits intoSwiftGen:masterfrom Nov 9, 2016
Merged
Templates for Swift 3 Compliant with API Design Guidelines#194dostrander merged 4 commits intoSwiftGen:masterfrom
dostrander merged 4 commits intoSwiftGen:masterfrom
Conversation
Closed
Collaborator
|
@afonsograca this looks good, just need an update with master :) |
Contributor
Author
|
@dostrander done! This also solves a namespace issue that I came across today. Given the following strings: This creates a static string called |
Collaborator
|
@afonsograca NICE that was one of the problems I had when I had attempted the |
Collaborator
|
@dostrander don't forget to add CHANGELOG entries as you merge PRs 😉 so we keep track of changes as we merge them and avoid forgetting them later at release time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to comply to SE-0023, some changes had to be made to the template stencils. Specifically: