Consider all installed toolchains in cache key#293
Merged
Swatinem merged 2 commits intoSwatinem:masterfrom Dec 16, 2025
Merged
Conversation
Swatinem
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves an issue we see in github.com/aya-rs/aya -- that project and
projects that use it often need a stable toolchain for the userspace side and a
nightly toolchain for eBPF (since it is a tier 3 target at the moment).
The current behavior before this PR results in a cache key derived from
whichever toolchain is installed last producing problems such as the one we
addressed in
aya-rs/aya@c0fdbae.
Unfortunately our other workflows still install multiple toolchains; we can of
course work around this locally, but it seems better to resolve upstream. See
aya-rs/aya#1409 (review).