Only run macOsWorkaround() on macOS#206
Merged
Swatinem merged 2 commits intoSwatinem:masterfrom Sep 17, 2024
Merged
Conversation
Swatinem
approved these changes
Sep 12, 2024
Owner
Swatinem
left a comment
There was a problem hiding this comment.
I believe the underlying bug was fixed, so it should be possible to remove that workaround altogether.
Contributor
Author
|
Updated the PR with rebuilt dist, as it seemed to fail on the check-dist workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you run a workflow using ubuntu-latest and this action through nektos/act, it will hang during the save process due to
sudoawaiting user input because/usr/sbin/purgeisn't found (meaning you'll have to exec into the container and kill this sudo process to make it move on).This change makes it only try to run purge if you're actually on a macOS runner.