Skip to content

Node16 -> node20 upgrade should maybe have been a major version bump? #183

@TrueBrain

Description

@TrueBrain

This is more informational, and I just wanted to let you know:

For most Rust-based workflows, we use your action, as it really helps out with setup etc. So I am really grateful for the work you put in here, and keeping it maintained. So first off: thank you!

Sadly, 2 days ago you made a new patch version (2.7.2) which most likely should have been a new major version (like 3.0.0). As most other actions at least did (actions/checkout and family). A node16 -> node20 upgrade is for most people not a small thing, and actually causes breakage of many workflows (as it does for us currently). Most actions left behind an older major version which was still node16 compatible, and went on with a new major version which was node20 compatible. This gives the opportunity to the user using the action when to upgrade.

There are some downsides to that approach, as everyone that wants to use node20 will need to bump their workflow to use the new major (assuming people follow @v2 in their workflows), but on the other hand it maintains workflows that depend on node16.

Sadly for us, we currently have no possibility to upgrade to node20 (we also don't run in the GitHub Runner itself). So for now I will be pinning our action to @v2.7.0. But I just wanted to let you know that this was kinda unexpected, as I can imagine it is not all that clear that a node upgrade is kinda a major thing :)

So again, just informational. As honestly, we really should have upgraded tot node20 already :P Tnx again for this action, I am very happy it exists!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions