fix(build): remove sourceMappingURL from svelte build#32
Merged
amen-souissi merged 1 commit intoSvelteStack:mainfrom Apr 7, 2021
Merged
fix(build): remove sourceMappingURL from svelte build#32amen-souissi merged 1 commit intoSvelteStack:mainfrom
amen-souissi merged 1 commit intoSvelteStack:mainfrom
Conversation
Collaborator
|
This is extremely useful! |
amen-souissi
approved these changes
Apr 7, 2021
Collaborator
|
Yes. 🙏 |
Collaborator
Author
|
Thanks @amen-souissi for merging this. |
Collaborator
|
@amen-souissi I can help you release this. You can give me permissions and I'll do it asap. 😃 |
Collaborator
|
V1.3.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This lib is excellent, I use it on a real world project and it helps a lot with query management.
After a couple of month using it, I have few suggestions and feedbacks about the lib.
I will try to help by contributing with some PRs.
Here is the first one.
During the build, this lib preprocess svelte files before packaging but the typescript preprocessor is relying on the
tsconfig.jsonbase file of the project so it produces sourceMaps files (which are not exported).This PRs fixes that behavior by passing the typescript preprocessor the good file to use.
Fixes #27