Skip to content

ENH: Add 4D float support#418

Merged
ViktorvdValk merged 1 commit intodevelopfrom
4D_image_support_elastix
Feb 16, 2021
Merged

ENH: Add 4D float support#418
ViktorvdValk merged 1 commit intodevelopfrom
4D_image_support_elastix

Conversation

@ViktorvdValk
Copy link
Copy Markdown
Member

No description provided.

@mstaring
Copy link
Copy Markdown
Member

More something for @stefanklein to comment on.

I am not sure we should change this default value. It is also possible to set this cmake flag externally when building elastix. Just override this cmake option for ITKELastix.

Copy link
Copy Markdown
Member

@stefanklein stefanklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it seems a good idea to enable it by default, if that's what ITKElastix requires as well, in order to keep things simple (instead of having different defaults for command-line and itkelastix). The only downside of adding "float" here is that compilation time increases. The advantage is that users who have sufficient memory can use the floating point precision without having to compile elastix themselves.

@mstaring
Copy link
Copy Markdown
Member

agreed then!

@ViktorvdValk ViktorvdValk merged commit 7677baf into develop Feb 16, 2021
@ViktorvdValk ViktorvdValk deleted the 4D_image_support_elastix branch February 16, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants