Skip to content

Let ComputeJacobianTerms::Compute return the terms, and other style improvements in "Common/itkCompute*.*"#1272

Merged
N-Dekker merged 6 commits intomainfrom
Common-Compute
Nov 28, 2024
Merged

Let ComputeJacobianTerms::Compute return the terms, and other style improvements in "Common/itkCompute*.*"#1272
N-Dekker merged 6 commits intomainfrom
Common-Compute

Conversation

@N-Dekker
Copy link
Copy Markdown
Member

No description provided.

Following C++ Core Guidelines, Oct 3, 2024:

 - "By default, make member functions `const`", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rconst-fct
 - "Don’t make a function `virtual` without reason", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-virtual
Following C++ Core Guidelines, Oct 3, 2024:

 - "By default, make member functions `const`", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rconst-fct
 - "Don’t make a function `virtual` without reason", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-virtual
Following C++ Core Guidelines, Oct 3, 2024, "For “out” output values, prefer return values to output parameters", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-out
Following C++ Core Guidelines, Oct 3, 2024, "For “out” output values, prefer return values to output parameters", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-out
Each of those duplicated typedefs were only used once, to declare a local `computeJacobianTerms` variable.

Also added `const` to those local variables.
@N-Dekker N-Dekker merged commit 87b7586 into main Nov 28, 2024
@N-Dekker N-Dekker deleted the Common-Compute branch November 28, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant