Conversation
`DerivativeValueType` is just a floating point type. In both AdvancedImageToImageMetric and SingleValuedPointSetToPointSetMetric, it is defined as:
using DerivativeValueType = typename DerivativeType::ValueType;
In ITK 5.4's SingleValuedCostFunction, DerivativeType is defined as:
using DerivativeType = Array<ParametersValueType>;
SingleValuedCostFunction is derived from CostFunction, which has:
using ParametersValueType = TInternalComputationValueType;
And for CostFunction, TInternalComputationValueType = double.
In LimiterFunctionBase, DerivativeValueType is defined as RealType:
using DerivativeValueType = OutputType;
OutputType is an alias of NumericTraits<TInput>::RealType
CorrespondingPointsEuclideanDistancePointMetric does not need to use those six types from its `Superclass`.
CorrespondingPointsEuclideanDistancePointMetric only uses VnlVectorType internally, in GetValueAndDerivative.
Replace `TransformParametersType` with `ParametersType` in "elastix\Components\Metrics\itk*.*"
`TransformParametersType` and `ParametersType` _must_ be exactly the same type, in order to override those virtual `itk::SingleValuedCostFunction` member functions from ITK 5.4.0:
GetValue(const ParametersType & parameters) const
GetDerivative(const ParametersType & parameters, DerivativeType & derivative) const
GetValueAndDerivative(const ParametersType & parameters, MeasureType & value, DerivativeType & derivative) const
"Components/Metrics" just does not need those TransformParametersType typedefs.
Removed unused `Superclass1` and `Superclass2` using-declarations from the class definition of `elx::CorrespondingPointsEuclideanDistancePointMetric`. Also removed ITKBaseType (which is a "typedef", rather than a "using-declarations").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.