PERF: EuclideanDistanceMetric get vector norm without GetVnlVector()#1237
Merged
PERF: EuclideanDistanceMetric get vector norm without GetVnlVector()#1237
Conversation
Removed unnecessary conversion from `itk::Vector` to vnl_vector, when retrieving the norm (the magnitude) of a vector (movingPoint - mappedPoint), in `CorrespondingPointsEuclideanDistancePointMetric`. Appears to make `GetValue` more that 7 times faster (from more than 0.07 sec. down to less than 0.009 sec. on 1 million 3D points), as observed on Visual C++ 2022.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary conversion from
itk::Vectorto vnl_vector, when retrieving the norm (the magnitude) of a vector (movingPoint - mappedPoint), inCorrespondingPointsEuclideanDistancePointMetric.Appears to make
GetValuemore that 7 times faster (from more than 0.07 sec. down to less than 0.009 sec. on 1 million 3D points), as observed on Visual C++ 2022.For the record,
GetDerivativeappears to have become more than 3 times faster, from more than 0.10 sec down to less than 0.03 sec, with this commit.