Skip to content

Remove ReadLandmarks from StatisticalShapePenalty, make it private in CorrespondingPointsEuclideanDistanceMetric#1232

Merged
N-Dekker merged 2 commits intomainfrom
Remove-StatisticalShapePenalty-ReadLandmarks
Sep 4, 2024
Merged

Remove ReadLandmarks from StatisticalShapePenalty, make it private in CorrespondingPointsEuclideanDistanceMetric#1232
N-Dekker merged 2 commits intomainfrom
Remove-StatisticalShapePenalty-ReadLandmarks

Conversation

@N-Dekker
Copy link
Copy Markdown
Member

@N-Dekker N-Dekker commented Sep 4, 2024

No description provided.

It appears that `StatisticalShapePenalty::ReadLandmarks` was never used. It appears to be copied from `CorrespondingPointsEuclideanDistanceMetric::ReadLandmarks`.

For the record, `StatisticalShapePenalty::ReadLandmarks` was introduced with commit 0d330fb "ENH: -Add the StatisticalShapePenalty metric module", Floris Berendsen, 13 May 2013.
Made `CorrespondingPointsEuclideanDistanceMetric::ReadLandmarks` private, instead of public, as it is only called by `CorrespondingPointsEuclideanDistanceMetric::BeforeRegistration()`.
@N-Dekker N-Dekker merged commit ab46400 into main Sep 4, 2024
@N-Dekker N-Dekker deleted the Remove-StatisticalShapePenalty-ReadLandmarks branch September 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant