adding support for low memory dataframes#76
Merged
brifordwylie merged 4 commits intomasterfrom Sep 3, 2019
Merged
Conversation
Closed
Member
Author
This was referenced Sep 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR based on some of the concepts in #75 but keeping the 'generator' for bro_log_reader (most folks using that class will definitely need/want a generator instead of a dataframe). Also instead of creating a large dataframe and then compressing we try to bring the data into the dataframe with categorical type directly. Also we make the changes compatible with the Parquet/Arrow conversions.
Note: This PR is still a WIP, we still have lots of improvements and testing to conduct.