Conversation
| } | ||
|
|
||
| fwrite($config_build_fp, json_encode($config_build_data), JSON_PRETTY_PRINT); | ||
| fclose($config_build_fp); |
There was a problem hiding this comment.
if (file_put_contents($config_build_file, json_encode($config_build_data, JSON_PRETTY_PRINT)) === false) {
die("Failed to write file {$config_build_file}");
}
as this'll handle fopen and all that for us.
bin/build_config_upload.py
Outdated
|
|
||
| # ------------------------------------------------------------------------ | ||
| def buildAll() : | ||
| for file in glob.glob("/var/local/submitty/to_be_built/*.json") : |
There was a problem hiding this comment.
Please don't use file as a variable name as that's a builtin for python. filename perhaps?
|
@MasterOdin The upload config page still needs some work. At the minimum, it should say what version was just uploaded (a copy paste line that can be inserted into the add-or-edit-gradeable page). And it would be nice to have it refresh automatically when the build output finishes (requires reload now). And it would be great to see file names and even file contents for previous uploads. Do you want to add to this PR, or a later PR? |
|
I added a list of uploaded directories (without file lists) which will do for now and more features can come later. |
|
Travis is currently down with the AWS outage so merging this without them for the time being. |
No description provided.