[Feature:RainbowGrades] Registration type in grade summaries#8026
Merged
[Feature:RainbowGrades] Registration type in grade summaries#8026
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8026 +/- ##
============================================
- Coverage 22.20% 22.19% -0.01%
Complexity 7581 7581
============================================
Files 203 203
Lines 24775 24775
Branches 60 60
============================================
- Hits 5501 5500 -1
- Misses 19216 19217 +1
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. |
bmcutler
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
The grade summaries for rainbow grades do not include registration type.
Closes #7474
What is the new behavior?
The JSON files used by rainbow grades now have the registration type included.
Other information?
I tested by setting various registration types in the sample course. Then after generating the grade summaries, checking the JSON files to see that the correct "registration_type" property is set.