[Feature:InstructorUI] Course Users Registration Type#7808
[Feature:InstructorUI] Course Users Registration Type#7808bmcutler merged 11 commits intoSubmitty:masterfrom
Conversation
…74-users-reg-type-column
…74-users-reg-type-column
Codecov Report
@@ Coverage Diff @@
## master #7808 +/- ##
============================================
- Coverage 22.08% 22.07% -0.01%
- Complexity 7496 7509 +13
============================================
Files 199 199
Lines 24519 24541 +22
Branches 54 54
============================================
+ Hits 5414 5417 +3
- Misses 19051 19070 +19
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. |
| :param course: Code of course being migrated | ||
| :type course: str | ||
| """ | ||
| pass |
There was a problem hiding this comment.
may want to drop the row and revert the constraint changes here
There was a problem hiding this comment.
I was thinking about that too but it says in the migration documentation
In general, your down migration should only undo the necessary changes to make earlier versions of the Submitty software work. For example, if your migration is adding a column to an existing table in the database, it is probably not necessary or desirable to delete that data in the down function. We don’t want to lose any data since we likely plan to return to this state in the future. Your down function may be empty.
`
And then my up function drops the constraint for in case anyone changes it
| {% for registration, students in sections %} | ||
| <tbody id="section-{{ registration }}"> | ||
| <tr class="info"> | ||
| <th class="section-break" colspan="10">Students Enrolled in Registration Section {{ registration }}</td> |
There was a problem hiding this comment.
i feel like this value has been changed a few times. Is there any way to set it to a value? Like {{ header|length }} or something passed in from the View? Not necessary but could save someone from future grief.
| <label for="registration_type" class="full-width"> | ||
| Registration Type: | ||
| <select name="registration_type" id="registration_type"> | ||
| <option value="graded">graded</option> |
There was a problem hiding this comment.
Also nitpicky, but we could possibly refactor this like the other input options to use something like {% for reg in reg_types %}
Please check if the PR fulfills these requirements:
What is the current behavior?
Progress on #7474
What is the new behavior?
registration_typecolumn to course_db'suserstable, which is constrained to values 'graded' (default), 'audit', 'withdrawn', and 'staff'groupis changed to be a grader or instructor, then the dropdown disappears because the registration type will default to 'staff'.