[Feature:TAGrading] highlight pos/neg marks w/ count up/down #4170
Merged
[Feature:TAGrading] highlight pos/neg marks w/ count up/down #4170
Conversation
Member
|
Please add a couple screenshots to illustrate the changes. Also we should add some screenshots/documentation on submitty.org :) Thanks! |
Kevin-MM
suggested changes
Jul 24, 2019
Contributor
Kevin-MM
left a comment
There was a problem hiding this comment.
Works well on Firefox, but not working on Chrome =(.
Contributor
Author
|
What component because I tested it in both? |
Contributor
|
I tried in Future (No TAs) Homework in the Edit Gradeable page and the TA grading interface. No luck. |
Contributor
Author
|
ok i will go back and see what is up |
Kevin-MM
approved these changes
Jul 24, 2019
Contributor
Kevin-MM
left a comment
There was a problem hiding this comment.
My mistake chrome was caching so I didn't get the updates immediately. Everything works well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Closes #3413
What is the new behavior?
Now, when you change the count up/count down grading guideline, any component score that doesn't comply is highlighted. It becomes unhighlighted when you change it to comply.
Other information?
Testing:
If the score is negative on count up, it should be highlighted and vice versa. Changing the score to comply should remove the highlight.