Option for Clearing All Rotating Section Assignments#3361
Merged
bmcutler merged 1 commit intoSubmitty:masterfrom Mar 24, 2019
zjxiaohan:drop_all
Merged
Option for Clearing All Rotating Section Assignments#3361bmcutler merged 1 commit intoSubmitty:masterfrom zjxiaohan:drop_all
bmcutler merged 1 commit intoSubmitty:masterfrom
zjxiaohan:drop_all
Conversation
emaicus
approved these changes
Mar 22, 2019
Contributor
emaicus
left a comment
There was a problem hiding this comment.
This PR works as intended for both team and individual assignments and should be ready to go. As we continue to iterate on the rotating section portion of the manage sections page, we might want to take some time to consider its layout. It strikes me as odd that of the four options on the manage rotating sections form, only the final radio button, Redo rotating sections completely makes use of the interface for placing students into rotating sections, which dominates the form. Perhaps we should consider hiding this section of the GUI until the redo rotating sections completely radio button is selected.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2366
This pull request adds another option for clearing all rotating section assignments, in other words, this option makes all the assigned rotating sections of students/teams NULL.